Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROO-2236] fix: explicitly import instead of window. to support code node in n… #5

Merged

Conversation

nadine-nguyen
Copy link
Collaborator

@nadine-nguyen nadine-nguyen commented Aug 23, 2024

…odejs

Description

Removing reference of window in order for @lexical/code to be used in node.js (headless editor)

Closes #

Test plan

Before

Insert relevant screenshots/recordings/automated-tests

After

Insert relevant screenshots/recordings/automated-tests

Copy link

size-limit report 📦

Path Size
lexical - cjs 29.38 KB (0%)
lexical - esm 29.24 KB (0%)
@lexical/rich-text - cjs 37.74 KB (0%)
@lexical/rich-text - esm 31.05 KB (0%)
@lexical/plain-text - cjs 36.41 KB (0%)
@lexical/plain-text - esm 28.42 KB (0%)
@lexical/react - cjs 39.61 KB (0%)
@lexical/react - esm 32.52 KB (0%)

@nadine-nguyen nadine-nguyen marked this pull request as ready for review August 23, 2024 04:46
@nadine-nguyen nadine-nguyen changed the title fix: explicitly import instead of window. to support code node in n… [ROO-2236] fix: explicitly import instead of window. to support code node in n… Aug 23, 2024
@nadine-nguyen nadine-nguyen merged commit e2fefb2 into main Aug 27, 2024
45 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants