-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix SIGUSR1 signal incompatible windows bug. #51541
base: master
Are you sure you want to change the base?
Conversation
xxx.go:64:3: undefined: syscall.SIGUSR1 xxx.go:65:3: undefined: syscall.SIGUSR2 xxx.go:68:3: undefined: syscall.SIGTSTP xxx.go:111:5: undefined: syscall.SIGUSR1 xxx.go:112:5: undefined: syscall.SIGUSR2 xxx.go:115:5: undefined: syscall.SIGTSTP xxx.go:119:5: undefined: syscall.SIGUSR1 xxx.go:120:5: undefined: syscall.SIGUSR2 xxx.go:123:5: undefined: syscall.SIGTSTP xxx.go:224:3: undefined: syscall.Kill xxx.go:224:3: too many errors after fixing, it can be compiled normally The items in question are: fvbock/endless#30
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
This PR (HEAD: 1a70eff) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/390695 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/390695. |
Message from mzh: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/390695. |
Should this have been approved? The CL has comments not addressed & the patch includes an implementation of Kill that silently does nothing, which is very different from what the JS implementation does. cc @ianlancetaylor (Edit: I think I got confused because it seems Github lets anyone approve PRs but only people with write access can merge them?) |
xxx.go:64:3: undefined: syscall.SIGUSR1
xxx.go:65:3: undefined: syscall.SIGUSR2
xxx.go:68:3: undefined: syscall.SIGTSTP
xxx.go:111:5: undefined: syscall.SIGUSR1
xxx.go:112:5: undefined: syscall.SIGUSR2
xxx.go:115:5: undefined: syscall.SIGTSTP
xxx.go:119:5: undefined: syscall.SIGUSR1
xxx.go:120:5: undefined: syscall.SIGUSR2
xxx.go:123:5: undefined: syscall.SIGTSTP
xxx.go:224:3: undefined: syscall.Kill
xxx.go:224:3: too many errors
after fixing, it can be compiled normally
The items in question are: fvbock/endless#30
This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.
Please ensure you adhere to every item in this list.
More info can be found at https://github.com/golang/go/wiki/CommitMessage
net/http: frob the quux before blarfing
"This change modifies Go to ___________"
really needed (ASCII art, table, or long link)
Fixes #1234
orUpdates #1234
(the latter if this is not a complete fix) to this comment
golang/go
you can use theowner/repo#issue_number
syntax:Fixes golang/tools#1234
Our Gerrit server & GitHub bots enforce CLA compliance instead.