Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New linter: Go responsewriter lint #3614

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

New linter: Go responsewriter lint #3614

wants to merge 6 commits into from
+95 −0

Commits on Feb 18, 2023

  1. Added linter specific testdata file

    @javorszky
    javorszky committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    0d3f690 View commit details
    Browse the repository at this point in the history

  2. Add all configs, structs and entries that the linter needs

    @javorszky
    javorszky committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    17eb3fc View commit details
    Browse the repository at this point in the history

  3. Update pkg/lint/lintersdb/manager.go 

    Accepted suggestion.

Co-authored-by: Ludovic Fernandez <[email protected]>
    @javorszky @ldez
    javorszky and ldez authored Feb 18, 2023
    Configuration menu
    Copy the full SHA
    30c9403 View commit details
    Browse the repository at this point in the history

  4. Rework imports to goimports is happy

    @javorszky
    javorszky committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    395eef3 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. Don't pass in nil config, especially not reassign's if linter isn't u… 

    …sing it


Good catch @leonklingele, thank you!

Co-authored-by: leonklingele <[email protected]>
    @javorszky @leonklingele
    javorszky and leonklingele authored Feb 19, 2023
    Configuration menu
    Copy the full SHA
    09734de View commit details
    Browse the repository at this point in the history

  2. Remove unused config import

    @javorszky
    javorszky committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    75019a3 View commit details
    Browse the repository at this point in the history