Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved coroutine usage in the ViewModels #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Moved coroutine usage in the ViewModels #167

wants to merge 1 commit into from

Conversation

angelomarzocchi
Copy link

Updated Gradle clean task to make it compatible with new Gradle version.
I also moved couroutine usage in the ViewModel for 2 reasons:

  1. it better follows the single responability principle: I don't see why calling a coroutine is a responsability of the UI.
  2. The problem of the update cancelled when recomposition is being performed is not an issue anymore :)

@angelomarzocchi
Updated dependencies.
7cee7ae 
Updated Gradle clean task to make it compatible with new Gradle version.
Moved coroutine usage in the ViewModel, where it belongs.
@angelomarzocchi angelomarzocchi changed the title Updated dependencies. Moved coroutine usage in the ViewModels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@angelomarzocchi