-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Windows Platform #227
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you check that this worked on unix-based environments as well? I will try and confirm that it does before merging this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I haven't check it on unix-based environments. It will be great if you can do this.
@NingLi670 @crawles Tried it on windows. I am running cmd in admin mode. |
Three changes make AndroidWorld runnable on Windows operating system:
/tmp
to automatically obtain it according to the operating system.os.path.join
intostr(Path(*args).as_posix())
to adapt to the path in posix format.strip()
to deal with\r
in Windows platform.More changes you need to do to make it work on WIndows Platform:
~/Library/Android/sdk/emulator/emulator
, start theemulator.exe
from another path. Usually it is~\AppData\Local\Android\Sdk\emulator\emulator.exe
._find_adb_directory
inminimal_task_runner.py
andrun.py
._increase_file_descriptor_limit
inenv_launcher.py
.