Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERA5T Support - Cloud Run Job Migration #95
base: main
Are you sure you want to change the base?
ERA5T Support - Cloud Run Job Migration #95
Changes from 1 commit
f63fc58
bc88a1a
1e4fe62
03de5a1
1420295
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the branch name before merging this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Python 3.8 is concerning to me. Python 3.8 is very old, already at end of life. This means it no longer receives security updates: https://devguide.python.org/versions/
Even Python 3.9 will soon be at end of life. We should strive to use newer versions of Python which are actively maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed @shoyer. The plan is to remove this
environment.yml
andDocker
entirely from the repository. As most of the code is working without these ondataflow
. Also we'll definitely upgrade with the newer python version and latestzarr
version (v3
) in future.