Perform filename normalization for diff #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is tricky - I don't think we should be munging file names by default. One idea: check if the local file system does this, and only enable it if so. |
|
BTW, while at it... could also try case folding as well, to better handle Windows systems. Also as an option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a file named to
ガールズ.txtis always synchronized with Mac OS which uses HFS+ file system.This is because HFS+ file performs NFD like filename normalization.
ガisU+30ACin NFC andU+30AB U+3099in NFD.With this PR,
adb-syncperforms filename NFC normalization for diff as default.With
--no-file-name-normalize, it does not.