Remove code from EclipseHack that is apparently no longer needed.
#1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_main_602524517
branch
2 times, most recently
from
14a55ed to
de05a14
Compare
`CompileWithEclipseTest` still passes with these removals, which suggests that the Eclipse bugs that made this code necessary have been fixed. RELNOTES=n/a PiperOrigin-RevId: 602802059
copybara-service
bot
force-pushed
the
test_main_602524517
branch
from
de05a14 to
f9ac6a2
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
f9ac6a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code from
EclipseHackthat is apparently no longer needed.CompileWithEclipseTeststill passes with these removals, which suggests thatthe Eclipse bugs that made this code necessary have been fixed.
RELNOTES=n/a