Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from pkg:pedantic to pkg:dart_flutter_team_lints #1314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented May 6, 2024

No description provided.

@kevmoo kevmoo requested a review from davidmorgan May 6, 2024 18:57
@davidmorgan
Copy link
Collaborator

Thanks!

Hmmmm there are some lint errors.

Looking at the lint set, I'm not super convinced ... ones that look worth fixing:

avoid_function_literals_in_foreach_calls
directives_ordering
unnecessary_lambdas
unnecessary_parenthesis
use_super_parameters

Problematic:

avoid_catching_errors ... is just wrong, sometimes you have to catch errors and this pushes people to do the wrong thing
prefer_const_constructors ... is a flutterism
prefer_relative_imports ... consistency here would be good but I'm not aware of a style push?
avoid_dynamic_calls, return_of_invalid_type, for_in_of_invalid_type, map_type_not_assignable, inference_failure_on_untyped_parameter ... these all relate to strict inference and will force changes to the code, are we sure those are equivalent?
lines_longer_than_80_chars ... I seem to remember this has false positives, maybe it doesn't any more
use_is_even_rather_than_modulo ... does not seem worth it

I didn't check for lints that are not enabled after the switch from pedantic.

Not really sure where to go with this, any suggestions? :)

@kevmoo
Copy link
Collaborator Author

kevmoo commented May 7, 2024 via email

@dave26199
Copy link

It might be dead but it hasn't stopped moving yet ;) with over 2000 users on pub.

I agree it'd be good to move off, do we need a script that diffs the lint set, then switches to a new base with the diff undone on top of it so it's a no-op?

@kevmoo
Copy link
Collaborator Author

kevmoo commented May 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants