Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce RTL support using BSv5 RTLCSS #1442

Closed
22 tasks done
Tracked by #1510 ...
chalin opened this issue Feb 25, 2023 · 7 comments
Closed
22 tasks done
Tracked by #1510 ...

Reintroduce RTL support using BSv5 RTLCSS #1442

chalin opened this issue Feb 25, 2023 · 7 comments
Labels
bootstrap i18n Internationalization / Localization
Milestone

Comments

@chalin
Copy link
Collaborator

chalin commented Feb 25, 2023

In our move to Bootstrap v5 (BSv5), we are adopting the Bootstrap approach to RTL, as described in https://getbootstrap.com/docs/5.3/getting-started/rtl/. The good news is that we don't have to rename all properties that have logical counterparts (at least for now), since RTLCSS handles their translation appropriately.

24H2 work

24H1 work - some of it reverted in H2

Entries processed (either ok as is, or reverted in whole or part), are marked with ⤴.


Related:

Notes:

Other:

This was referenced Feb 25, 2023
@chalin chalin mentioned this issue May 4, 2023
14 tasks
@chalin chalin added this to the 24Q2 milestone Nov 8, 2023
@chalin chalin modified the milestones: 24Q2, 24Q3 Jan 11, 2024
@nate-double-u
Copy link

I think we may need some upstream help to support an Arabic localization for the kubernetes.io website (using Docsy as a theme).

And to link this issue to the Kubernetes site more generally, I think solving this issue will also go toward solving kubernetes/website#22730

/cc @mboukhalfa, @a-mccarthy, @sftim

@chalin
Copy link
Collaborator Author

chalin commented Feb 7, 2024

All: as I mentioned in Slack, BS's RTL support is experimental:

Bootstrap's RTL feature is still experimental and will evolve based on user feedback. Spotted something or have an improvement to suggest? Open an issue, we'd love to get your insights.

@a-mccarthy
Copy link

+1 @nate-double-u, this would help enable new languages that have started or expressed interest in localizating Kubernetes documentation.

cc: @seokho-son

@chalin
Copy link
Collaborator Author

chalin commented Apr 24, 2024

@a-mccarthy @seokho-son : if you (and members of your community) could upvote this issue, it would help me assess the relative importance of the feature. Thanks.

@chalin chalin mentioned this issue Apr 26, 2024
25 tasks
@mboukhalfa
Copy link
Contributor

+1 this important since Arabic localization is in progress and expected to be alive on k8s website but the RTL issues are blocking even the preview of the progress ! this issue will greatly help

@Metal-Bat
Copy link

Metal-Bat commented Oct 13, 2024

loved the result
gona test it more surly

it had grate positioning and no weird display of persian characters
thanks for the effort
(translation was kinda clean just fixed a verb in pull request)

one more request kinda not sure is this the place for it or not
we lost the creator of 'vazir font' to cancer and we kinda like at least try to use his font in persian pages
(and it is great honestly and it was defualt for alot of things from the beginning)
is it posable to set in this font?
https://github.com/Rava-milad/vazir-font

@chalin
Copy link
Collaborator Author

chalin commented Oct 17, 2024

Thanks for taking a first look, and your willingness to try it out more thoroughly @Metal-Bat.

I'm going to move ahead and prepare the next official release of Docsy (#1944).

As for changing the font, see https://www.docsy.dev/docs/adding-content/lookandfeel/#fonts. I'll let others comment on how they adjust and/or include fonts, be it for multilingual projects or otherwise.

Closing this as it seems complete. I'll reopen or comment if there is more work to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap i18n Internationalization / Localization
Projects
None yet
Development

No branches or pull requests

5 participants