-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix contributor guide URL #4978
Conversation
…ributor guide url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @Metal-Bat.
LGTM, but ... I have a question for @open-telemetry/docs-maintainers: generally, an en
page fix must not be propagated to non-en
languages, since the locale maintainers need to update the default_lang_commit
too. We might want to make an exception when a 404 is being fixed? WDYT?
I'm leaning towards this PR be exclusively for en
pages. Other locales can handle their own page updates. But I'm willing to be convinced otherwise. I don't have a strong opinion about this.
/cc @emdneto
I think you are making a good point Thank you everyone |
+1. Exceptions might become unmanageable in the long run. |
Agred.
Thanks for the offer @Metal-Bat! Can you raise a dedicated issue for that? Note, that we need at least 2 people, 3 would be even better to work on that, since we as non-persian speakers can not help you with reviewing the content. Also note, that localizations are still a new thing to the OpenTelemetry website, so onboarding of new languages is still a slow process |
@Metal-Bat - please drop the non-en page changes from this PR. |
sure i will open an issue and i will find some people to start this documentation |
sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Thanks all!
@Metal-Bat et al. - heads up that Docsy (and hence this repo) doesn't fully support RTL languages yet. I'm working on it, but the feature might not land for a few weeks or months -- though I do see it happening before the end of the year. Reference: google/docsy#1442. |
great thanks |
fixes #4971