Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix flaky test #185

wants to merge 2 commits into from

Conversation

crawlingcub
Copy link

The test testSamplePairWithUnevenProbabilities always fails if the seed setting line is removed. A better way to test might be to check if the sampled value exists in the set of values that were put in the tree. This eliminates the dependence on seeds -- which may cause problems later.

Please let me know if this looks reasonable. I will be happy to incorporate any other suggestions that you may have. Thanks!

@google-cla
Copy link

google-cla bot commented Oct 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 4, 2021
@crawlingcub
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes CLA has been signed. and removed cla: no labels Oct 4, 2021
@crawlingcub
Copy link
Author

Hi, I fetched and updated the branch. Can you merge into master?

@psc-g
Copy link
Collaborator

psc-g commented Nov 12, 2021

hi, apologies for not getting back to you earlier.

at this point we're not taking external contributions (mostly for technical reasons). however, we're looking into changing this policy.

regarding setting the seed, i think your suggestion seems reasonable. if you don't mind, let's keep this issue open and we can come back to it once we've figured out the new policy for accepting external contributions.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants