Improve external texture image API #8395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflinger
force-pushed
the
ma/platform-external-image
branch
from
4759d8c to
87c0f52
Compare
z3moon
reviewed
Jan 31, 2025
bejado
approved these changes
Jan 31, 2025
| * @see PlatformCocoaGL::createExternalImage | ||
| * @see PlatformCocoaTouchGL::createExternalImage | ||
| */ | ||
| void setExternalImage(Engine& engine, ExternalImageHandleRef image) noexcept; |
There was a problem hiding this comment.
Is the idea that clients call the platform-specific createExternalImage and then pass that ref here?
pixelflinger
force-pushed
the
ma/platform-external-image
branch
from
87c0f52 to
5be382a
Compare
z3moon
approved these changes
Feb 2, 2025
The current API used a void* in Texture::setExternalImage to pass the platform specific image. This was a problem because on some platform like Android, there could be several types (EGLImageKHR and AHardwareBuffer), and with the void* there was no way to distinguish them on the backend / platform side. We now have a new Texture API which takes a Platform::ExternalImageHandle, which is a reference-counted handle to a Platform::ExternalImage. Platform::ExternalImage is an opaque type only known by the platform. This type must be created using a concrete Platform specific API, such as: PlatformEGL::createExternalImage PlatformEGLAndroid::createExternalImage PlatformCocoaGL::createExternalImage PlatformCocoaTouchGL::createExternalImage New types can easily be added in the future. There is no "destroy" call because the Platform::ExternalImageHandle is reference-counted and the client can let go of it as soon as it doesn't need it any longer (typically after calling Texture::setExternalImage). Platform::ExternalImage is a small structure that just anonymously wraps the concrete types. New internal driver APIs have been added to handle this functionality.
pixelflinger
force-pushed
the
ma/platform-external-image
branch
from
efa48b4 to
d2d2ab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current API used a void* in Texture::setExternalImage to pass the platform specific image. This was a problem because on some platform like Android, there could be several types (EGLImageKHR and AHardwareBuffer), and with the void* there was no way to distinguish them on the backend / platform side.
We now have a new Texture API which takes a
Platform::ExternalImageHandle, which is a reference-counted handle to a Platform::ExternalImage. Platform::ExternalImage is an opaque type only known by the platform.
This type must be created using a concrete Platform specific API, such as:
PlatformEGL::createExternalImage
PlatformEGLAndroid::createExternalImage
PlatformCocoaGL::createExternalImage
PlatformCocoaTouchGL::createExternalImage
New types can easily be added in the future.
There is no "destroy" call because the Platform::ExternalImageHandle is reference-counted and the client can let go of it as soon as it doesn't need it any longer (typically after calling Texture::setExternalImage). Platform::ExternalImage is a small structure that just anonymously wraps the concrete types.
New internal driver APIs have been added to handle this functionality.