Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: library definition for PlatformIO #8261

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

obones
Copy link

@obones obones commented Mar 15, 2024

Many embedded projects are using PlatfomIO as a development environment, in particular in the ESP32 world.

It is possible to use third party libraries via such a definition in the project platform.io file:

lib_deps = 
    https://github.com/boblemaire/asyncHTTPrequest

For this to work, the referenced project must include a library.json file describing the library and its folder layout.

This PR provides the file so that flatbuffers is usable as a dependency in PlatformIO, as requested by #7189

Copy link

google-cla bot commented Mar 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the json label Mar 15, 2024
Copy link
Contributor

This pull request is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 24, 2024
@obones
Copy link
Author

obones commented Sep 24, 2024

Hello
What can I do to "unstale" this branch?
I believe there needs to have an "approving review" but I'm not sure how to get this

@github-actions github-actions bot removed the stale label Sep 25, 2024
@FlavioZanoni
Copy link

@obones the branch is stale because it hasn't had any commits for the past few months. Have you signed the CLA ?

@obones
Copy link
Author

obones commented Oct 11, 2024

@obones the branch is stale because it hasn't had any commits for the past few months. Have you signed the CLA ?

I believe I did, at least that's what I inferred from the cla/google check being successful.

@FlavioZanoni
Copy link

FlavioZanoni commented Oct 11, 2024

I have created a PR to your branch to update the version in the library.json with the release. I think its just a matter of waiting for a maintainer

@obones
Copy link
Author

obones commented Oct 11, 2024

Thanks, I have merged it and rebased my branch on top of master.
Hopefully someone will notice this PR.

@sylque
Copy link

sylque commented Feb 3, 2025

So it seems this never got merged? Too bad...

@obones
Copy link
Author

obones commented Feb 3, 2025

So it seems this never got merged? Too bad...

Well, I just rebased it once more, for any one to look at.
I sincerely have no idea why "buildifier" is not happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants