Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists of the 21st of June #7876

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Lists of the 21st of June #7876

merged 5 commits into from
Jun 25, 2024

Conversation

emmamarichal
Copy link
Collaborator

@vv-monsalve, you can take a look for all the PW PRs. I put the new ones in "NEW", the rest is in "other"

cc @chrissimpkins

@m4rc1e, for the to_production list, I had to add almost all the Noto PRs by hand, same for the "other" section

@vv-monsalve
Copy link
Collaborator

@vv-monsalve, you can take a look for all the PW PRs. I put the new ones in "NEW", the rest is in "other"

Perfect! That was the idea. I reviewed them and they look good ;)

Copy link
Collaborator

@chrissimpkins chrissimpkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as we include the following PRs in the to_ lists:

#7838
#7792
googlefonts/lang#150

d/w Emma by Chat

@emmamarichal
Copy link
Collaborator Author

I've updated the to_sandbox with the last changes in Lang, but I'm not sure of the path. The changes are located in that folder: lang/Lib/gflanguages/data/languages/, but for the rest of the list, they are usually in lang/languages/

I want to be sure that is correct @chrissimpkins

@emmamarichal
Copy link
Collaborator Author

This PR can be merge once this one is merged: #7877

@emmamarichal emmamarichal merged commit aa4e92c into main Jun 25, 2024
9 of 10 checks passed
@emmamarichal emmamarichal deleted the to_lists_210624 branch June 25, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants