Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oi: Version 4.000 added #8353

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Oi: Version 4.000 added #8353

wants to merge 2 commits into from

Conversation

yanone
Copy link
Collaborator

@yanone yanone commented Oct 18, 2024

Taken from the upstream repo https://github.com/kosbarts/Oi at commit kosbarts/Oi@1938199.

Resolves #8075

PR Checklist:

  • minisite_url definition in the METADATA.pb file for commissioned projects
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

Copy link

FontBakery report

fontbakery version: 0.13.0a2

Check results

[25] Oi-Regular.ttf
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_Phonetics_SinoExt glyphset:

FAIL messages Languages
The locl feature did not affect Eng bm_Latn (Bambara), dyu_Latn (Dyula), ig_Latn (Igbo), lg_Latn (Ganda), bkm_Latn (Kom), tnr_Latn (Ménik), gde_Latn (Gude), bsc_Latn (Bassari), ee_Latn (Ewe), ken_Latn (Kenyang) and 245 more.
Shaper didn't attach uni0655 to the base glyph when shaping the text '‍ؤٕ' ar_Arab (Arabic)
Shaper didn't attach uni064D to the base glyph when shaping the text '‍ؤٍ' ar_Arab (Arabic) and fa_Arab (Persian)
Shaper didn't attach uni0650 to the base glyph when shaping the text '‍ؤِ' ar_Arab (Arabic)
Shaper didn't attach uni0655 to the base glyph when shaping the text '‍ئٕ' ar_Arab (Arabic)
Shaper didn't attach uni064D to the base glyph when shaping the text '‍ئٍ' ar_Arab (Arabic) and fa_Arab (Persian)
Shaper didn't attach uni0650 to the base glyph when shaping the text '‍ئِ' ar_Arab (Arabic)
Shaper didn't attach uni0670 to the base glyph when shaping the text '‍ىٰ' ar_Arab (Arabic)
Shaper didn't attach uni0653 to the base glyph when shaping the text '‍ىٓ' ar_Arab (Arabic)
Shaper didn't attach uni0654 to the base glyph when shaping the text '‍ىٔ' ar_Arab (Arabic)
Shaper didn't attach uni0655 to the base glyph when shaping the text '‍ىٕ' ar_Arab (Arabic)
Shaper didn't attach uni064B to the base glyph when shaping the text '‍ىً' ar_Arab (Arabic)
Shaper didn't attach uni064C to the base glyph when shaping the text '‍ىٌ' ar_Arab (Arabic)
Shaper didn't attach uni064D to the base glyph when shaping the text '‍ىٍ' ar_Arab (Arabic)
Shaper didn't attach uni064E to the base glyph when shaping the text '‍ىَ' ar_Arab (Arabic)
Shaper didn't attach uni064F to the base glyph when shaping the text '‍ىُ' ar_Arab (Arabic)
Shaper didn't attach uni0650 to the base glyph when shaping the text '‍ىِ' ar_Arab (Arabic)
Shaper didn't attach uni0651 to the base glyph when shaping the text '‍ىّ' ar_Arab (Arabic)
Shaper didn't attach uni0652 to the base glyph when shaping the text '‍ىْ' ar_Arab (Arabic)
.medi version of ARABIC LETTER ALEF MAKSURA; both buffers returned space=1+0 uni0649=1+1071
.init version of ARABIC LETTER ALEF MAKSURA; both buffers returned space=0+0 uni0649=0+1071
Shaper didn't attach uni064B to the base glyph when shaping the text '‍یً' fa_Arab (Persian)
Shaper didn't attach uni064D to the base glyph when shaping the text '‍یٍ' fa_Arab (Persian)
Shaper didn't attach uni064C to the base glyph when shaping the text '‍یٌ' fa_Arab (Persian)
Shaper didn't attach uni0651 to the base glyph when shaping the text '‍یّ' fa_Arab (Persian)
Shaper didn't attach uni0654 to the base glyph when shaping the text '‍یٔ' fa_Arab (Persian)
in Farsi, "saria heh" should use a small yeh above, not hamza; both buffers returned uni0654=0@96,338+0 uni0647=0+676
Some base glyphs were missing: ᵃ, ᵉ, ᵋ, ᵒ, ᵓ, ᶤ, ᶶ, ⁱ teo_Latn (Teso)
Some base glyphs were missing: Ɤ, Ɤ̀, Ɤ́, Ɤ̂, Ɤ̄, Ɤ̋, Ɤ̏ dnj_Latn (Dan)
Some base glyphs were missing: Ɤ, Ɤ̀, Ɤ́, Ɤ̂ gov_Latn (Goo)
[code: failed-language-shaping]
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: ἁ, ἃ, ἅ, ἆ, ἇ, ἑ, ἓ, ἕ, ἡ, ἣ, ἥ, ἦ, ἧ, ἱ, ἳ, ἵ, ἶ, ἷ, ὃ, ὑ, ὓ, ὕ, ὖ, ὗ, ὣ, ὥ, ὦ, ὧ, ᾶ, ῆ, ῖ, ῗ, ῦ, ῧ, ῶ el_Grek (Greek)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: ڜ ar_Arab (Arabic)
Some auxiliary glyphs were missing: ؀؁؂؃‌‍‎‏, ٗ, ٺ, ٻ, ټ, ٽ ur_Arab (Urdu)
No exemplar glyphs were defined for language Eastern Gurung, Latin ggn_Latn (Eastern Gurung, Latin)
No exemplar glyphs were defined for language Mina hna_Latn (Mina)
Some auxiliary glyphs were missing: ˈ lob_Latn (Lobi), cae_Latn (Lehar) and ndv_Latn (Ndut)
No variant glyphs were found for uni01A9 gaa_Latn (Ga)
No variant glyphs were found for uni01B7 gaa_Latn (Ga)
No exemplar glyphs were defined for language Seki syi_Latn (Seki)
No exemplar glyphs were defined for language Atsam cch_Latn (Atsam)
Some auxiliary glyphs were missing: Ƃ, ƃ dnj_Latn_LR (Liberian Dan)
No exemplar glyphs were defined for language Koro kfo_Latn (Koro)
No variant glyphs were found for uni028B tod_Latn (Toma)
No variant glyphs were found for uni01B2 tod_Latn (Toma)
No variant glyphs were found for uni0181 dnj_Latn (Dan)
No exemplar glyphs were defined for language Mbunga mgy_Latn (Mbunga)
No exemplar glyphs were defined for language Amo amo_Latn (Amo)
Some auxiliary glyphs were missing: ɐ, ɐ̀, ɐ́, ɐ̂, Ⓐ, ⓐ, Ɐ, Ɐ̀, Ɐ́, Ɐ̂ kib_Latn (Koalib)
[code: warning-language-shaping]
🔥 FAIL Does DESCRIPTION file contain broken links?
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
  • ⚠️ WARN

    Lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    dcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    tcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

⚠️ WARN Check if each glyph has the recommended amount of contours.
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: exclam	Contours detected: 1	Expected: 2
  • Glyph name: quotedbl Contours detected: 1 Expected: 2

  • Glyph name: percent Contours detected: 3 Expected: 4 or 5

  • Glyph name: equal Contours detected: 1 Expected: 2

  • Glyph name: question Contours detected: 1 Expected: 2

  • Glyph name: at Contours detected: 3 Expected: 2

  • Glyph name: i Contours detected: 1 Expected: 2

  • Glyph name: j Contours detected: 1 Expected: 2

  • Glyph name: exclamdown Contours detected: 1 Expected: 2

  • Glyph name: dieresis Contours detected: 1 Expected: 2

  • 899 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 617 among a set of 5 math glyphs.
    The following math glyphs have a different width, though:

Width = 619: greaterequal, greater, lessequal, less

Width = 618: logicalnot, plusminus

Width = 624: multiply

Width = 677: approxequal

[code: width-outliers]
⚠️ WARN Does the font contain a soft hyphen?
  • ⚠️ WARN

    This font has a 'Soft Hyphen' character.


    [code: softhyphen]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- KB

- dotabovear

- dotbelowar

- threedotsdownbelowar

- threedotsupabovear

- twodotshorizontalabovear

- twodotshorizontalbelowar

- uni0306.cy

- uni030C.alt

- uni0627.fina.short

- 4 more.

Use -F or --full-lists to disable shortening of long lists.

[code: unreachable-glyphs]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/oi does not have an article.


    [code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, cherokee, math, coptic
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: canadian-aboriginal, syriac, old-permic, tai-le, coptic, hebrew, tifinagh, todhri, malayalam, duployan, math
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+030D COMBINING VERTICAL LINE ABOVE: try adding sunuwar 300 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic, cyrillic-ext, greek, latin, latin-ext, menu, tamil, vietnamese

[code: unreachable-subsetting]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak.
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Do any segments have colinear vectors?
  • ⚠️ WARN

    The following glyphs have colinear vectors:

* KB: L<<483.0,685.0>--<421.0,491.0>> -> L<<421.0,491.0>--<354.0,302.0>>

[code: found-colinear-vectors]

⚠️ WARN Do outlines contain any jaggy segments?
  • ⚠️ WARN

    The following glyphs have jaggy segments:

* Euro (U+20AC): L<<18.0,512.0>--<183.0,512.0>>/B<<183.0,512.0>-<140.0,521.0>-<121.5,545.5>> = 11.821488340607226

* Ibreve (U+012C): B<<8.0,655.0>-<50.0,590.0>-<139.0,562.0>>/B<<139.0,562.0>-<68.0,604.0>-<32.5,680.5>> = 13.142480139666619

* Idieresis (U+00CF): B<<133.5,525.0>-<178.0,525.0>-<212.0,537.0>>/B<<212.0,537.0>-<157.0,531.0>-<110.5,551.0>> = 13.214205763750403

* Iotadieresis (U+03AA): B<<133.5,525.0>-<178.0,525.0>-<212.0,537.0>>/B<<212.0,537.0>-<157.0,531.0>-<110.5,551.0>> = 13.214205763750403

* Iotadieresis.calt: B<<133.5,525.0>-<178.0,525.0>-<212.0,537.0>>/B<<212.0,537.0>-<157.0,531.0>-<110.5,551.0>> = 13.214205763750403

* adieresis (U+00E4): B<<201.5,538.0>-<252.0,519.0>-<309.0,530.0>>/B<<309.0,530.0>-<261.0,532.0>-<220.5,555.5>> = 13.308748750258049

* cent (U+00A2): L<<552.0,762.0>--<552.0,546.0>>/B<<552.0,546.0>-<563.0,599.0>-<581.5,628.0>> = 11.725112015165063

* dollar (U+0024): L<<532.0,790.0>--<532.0,615.0>>/B<<532.0,615.0>-<548.0,682.0>-<622.0,698.0>> = 13.431028870681681

* edieresis (U+00EB): B<<236.5,531.5>-<278.0,521.0>-<323.0,530.0>>/B<<323.0,530.0>-<275.0,532.0>-<234.5,555.5>> = 13.695876504408998

* eight (U+0038): B<<66.5,350.5>-<101.0,392.0>-<168.0,428.0>>/B<<168.0,428.0>-<132.0,419.0>-<96.0,431.5>> = 14.213492027047774

* 130 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* Imacron (U+012A): L<<17.0,559.0>--<202.0,558.0>>

* Index_Right: L<<338.0,732.0>--<342.0,-2.0>>

* V (U+0056): L<<609.0,300.0>--<608.0,515.0>>

* ampersand (U+0026): L<<1252.0,351.0>--<976.0,350.0>>

* divide (U+00F7): L<<135.0,232.0>--<18.0,231.0>>

* ordfeminine (U+00AA): L<<221.0,539.0>--<396.0,540.0>>

* t (U+0074): L<<534.0,291.0>--<535.0,464.0>>

* t (U+0074): L<<781.0,501.0>--<505.0,500.0>>

* tau (U+03C4): L<<555.0,281.0>--<556.0,414.0>>

* tau (U+03C4): L<<807.0,451.0>--<526.0,450.0>>

* 158 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/oi


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/oi/Oi-Regular.ttf
Dehinted Size 541.7kb
Hinted Size 541.7kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 4.000']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 14 66 10 162 0
0% 0% 1% 6% 26% 4% 64% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@yanone
Copy link
Collaborator Author

yanone commented Oct 18, 2024

Ignore all Arabic mark attachment fails. I manually confirmed all of these to work. I don't understand why these reports are generated here.

Also ignore the report about ALEF MAKSURA, as the letter only exists in final and isolated form. This is incorrectly reported by youseedee; I'm investigating. Most likely a mistake in Unicode.

The saria heh as well as the missing African glyphs: This depends on when the font update was commissioned. The African is constantly improved, and the saria heh check in shaperglot was added 7 months ago, likely after the update was commissioned. I can't give a recommendation on whether or not these should be fixed.

@yanone
Copy link
Collaborator Author

yanone commented Oct 18, 2024

Also ignore all Eng fails. This uses the African Eng as default but shaperglot expects the European Eng as default, which needs to be defined in/for shaperglot. locl substitutions for European languages for this exist.

Copy link

FontBakery report

fontbakery version: 0.13.0a2

Check results

[25] Oi-Regular.ttf
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_Phonetics_SinoExt glyphset:

FAIL messages Languages
The locl feature did not affect Eng bm_Latn (Bambara), dyu_Latn (Dyula), ig_Latn (Igbo), lg_Latn (Ganda), bkm_Latn (Kom), tnr_Latn (Ménik), gde_Latn (Gude), bsc_Latn (Bassari), ee_Latn (Ewe), ken_Latn (Kenyang) and 245 more.
Shaper didn't attach uni0655 to the base glyph when shaping the text '‍ؤٕ' ar_Arab (Arabic)
Shaper didn't attach uni064D to the base glyph when shaping the text '‍ؤٍ' ar_Arab (Arabic) and fa_Arab (Persian)
Shaper didn't attach uni0650 to the base glyph when shaping the text '‍ؤِ' ar_Arab (Arabic)
Shaper didn't attach uni0655 to the base glyph when shaping the text '‍ئٕ' ar_Arab (Arabic)
Shaper didn't attach uni064D to the base glyph when shaping the text '‍ئٍ' ar_Arab (Arabic) and fa_Arab (Persian)
Shaper didn't attach uni0650 to the base glyph when shaping the text '‍ئِ' ar_Arab (Arabic)
Shaper didn't attach uni0670 to the base glyph when shaping the text '‍ىٰ' ar_Arab (Arabic)
Shaper didn't attach uni0653 to the base glyph when shaping the text '‍ىٓ' ar_Arab (Arabic)
Shaper didn't attach uni0654 to the base glyph when shaping the text '‍ىٔ' ar_Arab (Arabic)
Shaper didn't attach uni0655 to the base glyph when shaping the text '‍ىٕ' ar_Arab (Arabic)
Shaper didn't attach uni064B to the base glyph when shaping the text '‍ىً' ar_Arab (Arabic)
Shaper didn't attach uni064C to the base glyph when shaping the text '‍ىٌ' ar_Arab (Arabic)
Shaper didn't attach uni064D to the base glyph when shaping the text '‍ىٍ' ar_Arab (Arabic)
Shaper didn't attach uni064E to the base glyph when shaping the text '‍ىَ' ar_Arab (Arabic)
Shaper didn't attach uni064F to the base glyph when shaping the text '‍ىُ' ar_Arab (Arabic)
Shaper didn't attach uni0650 to the base glyph when shaping the text '‍ىِ' ar_Arab (Arabic)
Shaper didn't attach uni0651 to the base glyph when shaping the text '‍ىّ' ar_Arab (Arabic)
Shaper didn't attach uni0652 to the base glyph when shaping the text '‍ىْ' ar_Arab (Arabic)
.medi version of ARABIC LETTER ALEF MAKSURA; both buffers returned space=1+0 uni0649=1+1071
.init version of ARABIC LETTER ALEF MAKSURA; both buffers returned space=0+0 uni0649=0+1071
Shaper didn't attach uni064B to the base glyph when shaping the text '‍یً' fa_Arab (Persian)
Shaper didn't attach uni064D to the base glyph when shaping the text '‍یٍ' fa_Arab (Persian)
Shaper didn't attach uni064C to the base glyph when shaping the text '‍یٌ' fa_Arab (Persian)
Shaper didn't attach uni0651 to the base glyph when shaping the text '‍یّ' fa_Arab (Persian)
Shaper didn't attach uni0654 to the base glyph when shaping the text '‍یٔ' fa_Arab (Persian)
in Farsi, "saria heh" should use a small yeh above, not hamza; both buffers returned uni0654=0@96,338+0 uni0647=0+676
Some base glyphs were missing: ᵃ, ᵉ, ᵋ, ᵒ, ᵓ, ᶤ, ᶶ, ⁱ teo_Latn (Teso)
Some base glyphs were missing: Ɤ, Ɤ̀, Ɤ́, Ɤ̂, Ɤ̄, Ɤ̋, Ɤ̏ dnj_Latn (Dan)
Some base glyphs were missing: Ɤ, Ɤ̀, Ɤ́, Ɤ̂ gov_Latn (Goo)
[code: failed-language-shaping]
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: ἁ, ἃ, ἅ, ἆ, ἇ, ἑ, ἓ, ἕ, ἡ, ἣ, ἥ, ἦ, ἧ, ἱ, ἳ, ἵ, ἶ, ἷ, ὃ, ὑ, ὓ, ὕ, ὖ, ὗ, ὣ, ὥ, ὦ, ὧ, ᾶ, ῆ, ῖ, ῗ, ῦ, ῧ, ῶ el_Grek (Greek)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: ڜ ar_Arab (Arabic)
Some auxiliary glyphs were missing: ؀؁؂؃‌‍‎‏, ٗ, ٺ, ٻ, ټ, ٽ ur_Arab (Urdu)
No exemplar glyphs were defined for language Eastern Gurung, Latin ggn_Latn (Eastern Gurung, Latin)
No exemplar glyphs were defined for language Mina hna_Latn (Mina)
Some auxiliary glyphs were missing: ˈ lob_Latn (Lobi), cae_Latn (Lehar) and ndv_Latn (Ndut)
No variant glyphs were found for uni01A9 gaa_Latn (Ga)
No variant glyphs were found for uni01B7 gaa_Latn (Ga)
No exemplar glyphs were defined for language Seki syi_Latn (Seki)
No exemplar glyphs were defined for language Atsam cch_Latn (Atsam)
Some auxiliary glyphs were missing: Ƃ, ƃ dnj_Latn_LR (Liberian Dan)
No exemplar glyphs were defined for language Koro kfo_Latn (Koro)
No variant glyphs were found for uni028B tod_Latn (Toma)
No variant glyphs were found for uni01B2 tod_Latn (Toma)
No variant glyphs were found for uni0181 dnj_Latn (Dan)
No exemplar glyphs were defined for language Mbunga mgy_Latn (Mbunga)
No exemplar glyphs were defined for language Amo amo_Latn (Amo)
Some auxiliary glyphs were missing: ɐ, ɐ̀, ɐ́, ɐ̂, Ⓐ, ⓐ, Ɐ, Ɐ̀, Ɐ́, Ɐ̂ kib_Latn (Koalib)
[code: warning-language-shaping]
🔥 FAIL Does DESCRIPTION file contain broken links?
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
  • ⚠️ WARN

    Lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    dcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    tcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

⚠️ WARN Check if each glyph has the recommended amount of contours.
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: exclam	Contours detected: 1	Expected: 2
  • Glyph name: quotedbl Contours detected: 1 Expected: 2

  • Glyph name: percent Contours detected: 3 Expected: 4 or 5

  • Glyph name: equal Contours detected: 1 Expected: 2

  • Glyph name: question Contours detected: 1 Expected: 2

  • Glyph name: at Contours detected: 3 Expected: 2

  • Glyph name: i Contours detected: 1 Expected: 2

  • Glyph name: j Contours detected: 1 Expected: 2

  • Glyph name: exclamdown Contours detected: 1 Expected: 2

  • Glyph name: dieresis Contours detected: 1 Expected: 2

  • 899 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 617 among a set of 5 math glyphs.
    The following math glyphs have a different width, though:

Width = 619: greaterequal, lessequal, less, greater

Width = 618: logicalnot, plusminus

Width = 624: multiply

Width = 677: approxequal

[code: width-outliers]
⚠️ WARN Does the font contain a soft hyphen?
  • ⚠️ WARN

    This font has a 'Soft Hyphen' character.


    [code: softhyphen]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- KB

- dotabovear

- dotbelowar

- threedotsdownbelowar

- threedotsupabovear

- twodotshorizontalabovear

- twodotshorizontalbelowar

- uni0306.cy

- uni030C.alt

- uni0627.fina.short

- 4 more.

Use -F or --full-lists to disable shortening of long lists.

[code: unreachable-glyphs]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/oi does not have an article.


    [code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, cherokee, math, tifinagh
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: math, tai-le, tifinagh, hebrew, syriac, coptic, malayalam, todhri, canadian-aboriginal, duployan, old-permic
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  • U+030D COMBINING VERTICAL LINE ABOVE: try adding sunuwar 60 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: arabic, cyrillic, cyrillic-ext, greek, latin, latin-ext, menu, tamil, vietnamese

[code: unreachable-subsetting]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak.
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Do any segments have colinear vectors?
  • ⚠️ WARN

    The following glyphs have colinear vectors:

* KB: L<<483.0,685.0>--<421.0,491.0>> -> L<<421.0,491.0>--<354.0,302.0>>

[code: found-colinear-vectors]

⚠️ WARN Do outlines contain any jaggy segments?
  • ⚠️ WARN

    The following glyphs have jaggy segments:

* Euro (U+20AC): L<<18.0,512.0>--<183.0,512.0>>/B<<183.0,512.0>-<140.0,521.0>-<121.5,545.5>> = 11.821488340607226

* Ibreve (U+012C): B<<8.0,655.0>-<50.0,590.0>-<139.0,562.0>>/B<<139.0,562.0>-<68.0,604.0>-<32.5,680.5>> = 13.142480139666619

* Idieresis (U+00CF): B<<133.5,525.0>-<178.0,525.0>-<212.0,537.0>>/B<<212.0,537.0>-<157.0,531.0>-<110.5,551.0>> = 13.214205763750403

* Iotadieresis (U+03AA): B<<133.5,525.0>-<178.0,525.0>-<212.0,537.0>>/B<<212.0,537.0>-<157.0,531.0>-<110.5,551.0>> = 13.214205763750403

* Iotadieresis.calt: B<<133.5,525.0>-<178.0,525.0>-<212.0,537.0>>/B<<212.0,537.0>-<157.0,531.0>-<110.5,551.0>> = 13.214205763750403

* adieresis (U+00E4): B<<201.5,538.0>-<252.0,519.0>-<309.0,530.0>>/B<<309.0,530.0>-<261.0,532.0>-<220.5,555.5>> = 13.308748750258049

* cent (U+00A2): L<<552.0,762.0>--<552.0,546.0>>/B<<552.0,546.0>-<563.0,599.0>-<581.5,628.0>> = 11.725112015165063

* dollar (U+0024): L<<532.0,790.0>--<532.0,615.0>>/B<<532.0,615.0>-<548.0,682.0>-<622.0,698.0>> = 13.431028870681681

* edieresis (U+00EB): B<<236.5,531.5>-<278.0,521.0>-<323.0,530.0>>/B<<323.0,530.0>-<275.0,532.0>-<234.5,555.5>> = 13.695876504408998

* eight (U+0038): B<<66.5,350.5>-<101.0,392.0>-<168.0,428.0>>/B<<168.0,428.0>-<132.0,419.0>-<96.0,431.5>> = 14.213492027047774

* 130 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* Imacron (U+012A): L<<17.0,559.0>--<202.0,558.0>>

* Index_Right: L<<338.0,732.0>--<342.0,-2.0>>

* V (U+0056): L<<609.0,300.0>--<608.0,515.0>>

* ampersand (U+0026): L<<1252.0,351.0>--<976.0,350.0>>

* divide (U+00F7): L<<135.0,232.0>--<18.0,231.0>>

* ordfeminine (U+00AA): L<<221.0,539.0>--<396.0,540.0>>

* t (U+0074): L<<534.0,291.0>--<535.0,464.0>>

* t (U+0074): L<<781.0,501.0>--<505.0,500.0>>

* tau (U+03C4): L<<555.0,281.0>--<556.0,414.0>>

* tau (U+03C4): L<<807.0,451.0>--<526.0,450.0>>

* 158 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/oi


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/oi/Oi-Regular.ttf
Dehinted Size 541.7kb
Hinted Size 541.7kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 4.000']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 14 66 10 162 0
0% 0% 1% 6% 26% 4% 64% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@yanone
Copy link
Collaborator Author

yanone commented Oct 23, 2024

Update: The ALEF MAKSURA report is accurate, not a mistake, but it doesn't matter in this case. The letter is used in intial and medial form in Uyghur for example, but not in Arabic/Persian/Urdu, which this font here is targetting.

We're gonna have to get used to this report for now, as we currently have no way to separate this per glyphset because only one unicode is involved but two presentation forms of it are unnecessary (and uncommon in font files) for the major Arabic script orthographies.

@yanone
Copy link
Collaborator Author

yanone commented Oct 24, 2024

Also ignore the saria heh shaping FAIL. Simon mentioned that the respective issue notofonts/arabic#230 is still unsolved, so we should ignore it for now.

@emmamarichal
Copy link
Collaborator

Hi @yanone!

I'm not expert in Arabic, so I'm afraid I can't give a precise review for this. However, I noticed this, that looked weird to me:

Screenshot 2024-10-25 at 11 00 59 Screenshot 2024-10-25 at 11 06 02

It concerns /uni063A.medi/uni0641.fina/uni0641.medi/uni06A4.fina/uni06A4.medi/uni06A1.fina/uni06A1.medi/uni06A7.medi/uni06A8.medi

@yanone
Copy link
Collaborator Author

yanone commented Oct 25, 2024

That's not specific to Arabic, but an outline issue. I'll look into it, thank you.

Taken from the upstream repo https://github.com/kosbarts/Oi at commit kosbarts/Oi@5e2b01e.

Resolves #8075
@yanone
Copy link
Collaborator Author

yanone commented Oct 25, 2024

Updated

Copy link

FontBakery report

fontbakery version: 0.13.0a2

Check results

[25] Oi-Regular.ttf
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_Phonetics_SinoExt glyphset:

FAIL messages Languages
The locl feature did not affect Eng bm_Latn (Bambara), dyu_Latn (Dyula), ig_Latn (Igbo), lg_Latn (Ganda), bkm_Latn (Kom), tnr_Latn (Ménik), gde_Latn (Gude), bsc_Latn (Bassari), ee_Latn (Ewe), ken_Latn (Kenyang) and 245 more.
Shaper didn't attach uni0655 to the base glyph when shaping the text '‍ؤٕ' ar_Arab (Arabic)
Shaper didn't attach uni064D to the base glyph when shaping the text '‍ؤٍ' ar_Arab (Arabic) and fa_Arab (Persian)
Shaper didn't attach uni0650 to the base glyph when shaping the text '‍ؤِ' ar_Arab (Arabic)
Shaper didn't attach uni0655 to the base glyph when shaping the text '‍ئٕ' ar_Arab (Arabic)
Shaper didn't attach uni064D to the base glyph when shaping the text '‍ئٍ' ar_Arab (Arabic) and fa_Arab (Persian)
Shaper didn't attach uni0650 to the base glyph when shaping the text '‍ئِ' ar_Arab (Arabic)
Shaper didn't attach uni0670 to the base glyph when shaping the text '‍ىٰ' ar_Arab (Arabic)
Shaper didn't attach uni0653 to the base glyph when shaping the text '‍ىٓ' ar_Arab (Arabic)
Shaper didn't attach uni0654 to the base glyph when shaping the text '‍ىٔ' ar_Arab (Arabic)
Shaper didn't attach uni0655 to the base glyph when shaping the text '‍ىٕ' ar_Arab (Arabic)
Shaper didn't attach uni064B to the base glyph when shaping the text '‍ىً' ar_Arab (Arabic)
Shaper didn't attach uni064C to the base glyph when shaping the text '‍ىٌ' ar_Arab (Arabic)
Shaper didn't attach uni064D to the base glyph when shaping the text '‍ىٍ' ar_Arab (Arabic)
Shaper didn't attach uni064E to the base glyph when shaping the text '‍ىَ' ar_Arab (Arabic)
Shaper didn't attach uni064F to the base glyph when shaping the text '‍ىُ' ar_Arab (Arabic)
Shaper didn't attach uni0650 to the base glyph when shaping the text '‍ىِ' ar_Arab (Arabic)
Shaper didn't attach uni0651 to the base glyph when shaping the text '‍ىّ' ar_Arab (Arabic)
Shaper didn't attach uni0652 to the base glyph when shaping the text '‍ىْ' ar_Arab (Arabic)
Shaper didn't attach uni064B to the base glyph when shaping the text '‍یً' fa_Arab (Persian)
Shaper didn't attach uni064D to the base glyph when shaping the text '‍یٍ' fa_Arab (Persian)
Shaper didn't attach uni064C to the base glyph when shaping the text '‍یٌ' fa_Arab (Persian)
Shaper didn't attach uni0651 to the base glyph when shaping the text '‍یّ' fa_Arab (Persian)
Shaper didn't attach uni0654 to the base glyph when shaping the text '‍یٔ' fa_Arab (Persian)
in Farsi, "saria heh" should use a small yeh above, not hamza; both buffers returned uni0654=0@96,338+0 uni0647=0+676
Some base glyphs were missing: ᵃ, ᵉ, ᵋ, ᵒ, ᵓ, ᶤ, ᶶ, ⁱ teo_Latn (Teso)
Some base glyphs were missing: Ɤ, Ɤ̀, Ɤ́, Ɤ̂, Ɤ̄, Ɤ̋, Ɤ̏ dnj_Latn (Dan)
Some base glyphs were missing: Ɤ, Ɤ̀, Ɤ́, Ɤ̂ gov_Latn (Goo)
[code: failed-language-shaping]
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: ἁ, ἃ, ἅ, ἆ, ἇ, ἑ, ἓ, ἕ, ἡ, ἣ, ἥ, ἦ, ἧ, ἱ, ἳ, ἵ, ἶ, ἷ, ὃ, ὑ, ὓ, ὕ, ὖ, ὗ, ὣ, ὥ, ὦ, ὧ, ᾶ, ῆ, ῖ, ῗ, ῦ, ῧ, ῶ el_Grek (Greek)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: ڜ ar_Arab (Arabic)
Some auxiliary glyphs were missing: ؀؁؂؃‌‍‎‏, ٗ, ٺ, ٻ, ټ, ٽ ur_Arab (Urdu)
No exemplar glyphs were defined for language Eastern Gurung, Latin ggn_Latn (Eastern Gurung, Latin)
No exemplar glyphs were defined for language Mina hna_Latn (Mina)
Some auxiliary glyphs were missing: ˈ lob_Latn (Lobi), cae_Latn (Lehar) and ndv_Latn (Ndut)
No variant glyphs were found for uni01A9 gaa_Latn (Ga)
No variant glyphs were found for uni01B7 gaa_Latn (Ga)
No exemplar glyphs were defined for language Seki syi_Latn (Seki)
No exemplar glyphs were defined for language Atsam cch_Latn (Atsam)
Some auxiliary glyphs were missing: Ƃ, ƃ dnj_Latn_LR (Liberian Dan)
No exemplar glyphs were defined for language Koro kfo_Latn (Koro)
No variant glyphs were found for uni028B tod_Latn (Toma)
No variant glyphs were found for uni01B2 tod_Latn (Toma)
No variant glyphs were found for uni0181 dnj_Latn (Dan)
No exemplar glyphs were defined for language Mbunga mgy_Latn (Mbunga)
No exemplar glyphs were defined for language Amo amo_Latn (Amo)
Some auxiliary glyphs were missing: ɐ, ɐ̀, ɐ́, ɐ̂, Ⓐ, ⓐ, Ɐ, Ɐ̀, Ɐ́, Ɐ̂ kib_Latn (Koalib)
[code: warning-language-shaping]
🔥 FAIL Does DESCRIPTION file contain broken links?
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
  • ⚠️ WARN

    Lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    dcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    tcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

⚠️ WARN Check if each glyph has the recommended amount of contours.
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: exclam	Contours detected: 1	Expected: 2
  • Glyph name: quotedbl Contours detected: 1 Expected: 2

  • Glyph name: percent Contours detected: 3 Expected: 4 or 5

  • Glyph name: equal Contours detected: 1 Expected: 2

  • Glyph name: question Contours detected: 1 Expected: 2

  • Glyph name: at Contours detected: 3 Expected: 2

  • Glyph name: i Contours detected: 1 Expected: 2

  • Glyph name: j Contours detected: 1 Expected: 2

  • Glyph name: exclamdown Contours detected: 1 Expected: 2

  • Glyph name: dieresis Contours detected: 1 Expected: 2

  • 899 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 617 among a set of 5 math glyphs.
    The following math glyphs have a different width, though:

Width = 619: greater, less, greaterequal, lessequal

Width = 618: plusminus, logicalnot

Width = 624: multiply

Width = 677: approxequal

[code: width-outliers]
⚠️ WARN Does the font contain a soft hyphen?
  • ⚠️ WARN

    This font has a 'Soft Hyphen' character.


    [code: softhyphen]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- KB

- dotabovear

- dotbelowar

- threedotsdownbelowar

- threedotsupabovear

- twodotshorizontalabovear

- twodotshorizontalbelowar

- uni0306.cy

- uni030C.alt

- uni0627.fina.short

- 4 more.

Use -F or --full-lists to disable shortening of long lists.

[code: unreachable-glyphs]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/oi does not have an article.


    [code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, cherokee, math, coptic
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: math, tai-le, syriac, hebrew, tifinagh, todhri, coptic, old-permic, duployan, malayalam, canadian-aboriginal
  • U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  • U+030D COMBINING VERTICAL LINE ABOVE: try adding sunuwar 60 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: arabic, cyrillic, cyrillic-ext, greek, latin, latin-ext, menu, tamil, vietnamese

[code: unreachable-subsetting]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak.
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Do any segments have colinear vectors?
  • ⚠️ WARN

    The following glyphs have colinear vectors:

* KB: L<<483.0,685.0>--<421.0,491.0>> -> L<<421.0,491.0>--<354.0,302.0>>

[code: found-colinear-vectors]

⚠️ WARN Do outlines contain any jaggy segments?
  • ⚠️ WARN

    The following glyphs have jaggy segments:

* Euro (U+20AC): L<<18.0,512.0>--<183.0,512.0>>/B<<183.0,512.0>-<140.0,521.0>-<121.5,545.5>> = 11.821488340607226

* Ibreve (U+012C): B<<8.0,655.0>-<50.0,590.0>-<139.0,562.0>>/B<<139.0,562.0>-<68.0,604.0>-<32.5,680.5>> = 13.142480139666619

* Idieresis (U+00CF): B<<133.5,525.0>-<178.0,525.0>-<212.0,537.0>>/B<<212.0,537.0>-<157.0,531.0>-<110.5,551.0>> = 13.214205763750403

* Iotadieresis (U+03AA): B<<133.5,525.0>-<178.0,525.0>-<212.0,537.0>>/B<<212.0,537.0>-<157.0,531.0>-<110.5,551.0>> = 13.214205763750403

* Iotadieresis.calt: B<<133.5,525.0>-<178.0,525.0>-<212.0,537.0>>/B<<212.0,537.0>-<157.0,531.0>-<110.5,551.0>> = 13.214205763750403

* adieresis (U+00E4): B<<201.5,538.0>-<252.0,519.0>-<309.0,530.0>>/B<<309.0,530.0>-<261.0,532.0>-<220.5,555.5>> = 13.308748750258049

* cent (U+00A2): L<<552.0,762.0>--<552.0,546.0>>/B<<552.0,546.0>-<563.0,599.0>-<581.5,628.0>> = 11.725112015165063

* dollar (U+0024): L<<532.0,790.0>--<532.0,615.0>>/B<<532.0,615.0>-<548.0,682.0>-<622.0,698.0>> = 13.431028870681681

* edieresis (U+00EB): B<<236.5,531.5>-<278.0,521.0>-<323.0,530.0>>/B<<323.0,530.0>-<275.0,532.0>-<234.5,555.5>> = 13.695876504408998

* eight (U+0038): B<<66.5,350.5>-<101.0,392.0>-<168.0,428.0>>/B<<168.0,428.0>-<132.0,419.0>-<96.0,431.5>> = 14.213492027047774

* 130 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* Imacron (U+012A): L<<17.0,559.0>--<202.0,558.0>>

* Index_Right: L<<338.0,732.0>--<342.0,-2.0>>

* V (U+0056): L<<609.0,300.0>--<608.0,515.0>>

* ampersand (U+0026): L<<1252.0,351.0>--<976.0,350.0>>

* divide (U+00F7): L<<135.0,232.0>--<18.0,231.0>>

* ordfeminine (U+00AA): L<<221.0,539.0>--<396.0,540.0>>

* t (U+0074): L<<534.0,291.0>--<535.0,464.0>>

* t (U+0074): L<<781.0,501.0>--<505.0,500.0>>

* tau (U+03C4): L<<555.0,281.0>--<556.0,414.0>>

* tau (U+03C4): L<<807.0,451.0>--<526.0,450.0>>

* 161 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/oi


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/oi/Oi-Regular.ttf
Dehinted Size 541.8kb
Hinted Size 541.8kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 4.000']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 14 66 10 162 0
0% 0% 1% 6% 26% 4% 64% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: PR GF
Development

Successfully merging this pull request may close these issues.

Update Oi with Arabic
3 participants