-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Handling for urlConnection #2902
Error Handling for urlConnection #2902
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2902 +/- ##
============================================
- Coverage 62.97% 62.87% -0.11%
- Complexity 1287 1288 +1
============================================
Files 273 273
Lines 6723 6739 +16
Branches 933 937 +4
============================================
+ Hits 4234 4237 +3
- Misses 1872 1882 +10
- Partials 617 620 +3
|
ground/src/main/java/com/google/android/ground/ui/map/gms/mog/UrlInputStream.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/ui/map/gms/mog/UrlInputStream.kt
Outdated
Show resolved
Hide resolved
We should handle the error upstream where it can actually be addressed: Lines 100 to 113 in 9ef90ad
You would add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few requests, LG
...main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorViewModel.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorFragment.kt
Outdated
Show resolved
Hide resolved
...main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorViewModel.kt
Outdated
Show resolved
Hide resolved
…-timeout-exception' into anandwana001/2683/prevent-socket-timeout-exception
…xception # Conflicts: # app/src/main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorFragment.kt # app/src/test/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorViewModelTest.kt
…xception # Conflicts: # app/src/main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorViewModel.kt # app/src/test/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorFragmentTest.kt
Fixes #2683
Fixes #662
@shobhitagarwal1612 PTAL?