-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algorithmic decorator (implement output for _repr_latex_) #163
Merged
Merged
Changes from 30 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
2f3d060
fe decorator
8d90da0
infra
200b7fc
no longer cached
d71392c
rm import
a2bf524
codegen
6d9411c
tests & bugs
f5dc568
temp del
b2d8f4c
mv
a541944
copy back
8296cd1
make edit
fcb47fb
rm dup
ba36b5b
init alg
ZibingZhang 4fa59ee
Merge branch 'master' into algorithmic-decorator
ZibingZhang 5cf2fc4
Merge branch 'algorithmic-decorator' of github.com:ZibingZhang/latexi…
ZibingZhang d8b81f8
Merge branch 'master' into algorithmic-decorator
ZibingZhang 006821d
wrap up
ZibingZhang dafa24f
oop
ZibingZhang ffe0a14
testing
ZibingZhang 2a5a0b9
change back
ZibingZhang 7fbd048
suggestions
ZibingZhang eec0e70
Merge branch 'master' into algorithmic-decorator
ZibingZhang 65f8ab8
f strings >
ZibingZhang fb7612a
slight refactor
ZibingZhang 83bdb73
class arg
ZibingZhang b6bafe5
was weird
ZibingZhang 29ca5cb
final (?) suggestions
ZibingZhang 73ecd73
bad place for f string
ZibingZhang 55ec2cb
rm f
ZibingZhang 3f0ce8e
easier to read
ZibingZhang 4522756
didn't like my code from before
ZibingZhang 2a47c19
no +
ZibingZhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore the original expression, and don't use "+" concatenation as well as possible. f-strings or
join()
are basically the most fastest option to concatenate strings and "+" is the worst choice.Ditto for all other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, I think I've converted it all back. When codegen though lots of places can't use
f
strings because of\
not allowed :(