Refactor early-exit in data_collector into the WorkerPool. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, make scheduling work a method on the work pool. The local worker pool will continue to use the buffered scheduler, but alternative (distributed) worker pools will use alternative strategies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for an internal fix to speed up compilations on an internal worker pool implementation. The main point is that the checks for exiting early now are abstracted into a worker pool wrapper, so that distributed worker pools can check for early exiting independently of other hosts.
This PR also includes a function
compiler_opt.distributed.worker.lift_futures_through_listwhich converts aWorkerFuture[List]toList[WorkerFuture]. This is used in the same internal fix mentioned above.