Make make_corpus functions consistent with extract_ir functions #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrofin
reviewed
Aug 2, 2023
Currently the functions in make_corpus_lib assume they are working with a full file path whereas the tooling in extract_ir truncates the .bc/.cmd extensions and only has the object file. This discrepancy means that tooling that works with downstream products of corpora from extract_ir doesn't work without modification with corpora from make_corpus (ignoring the missing .cmd files). This patch makes make_corpus match the behavior of extract_ir.
boomanaiden154
force-pushed
the
make-corpus-file-extension
branch
from
d3320f9
to
84109e5
Compare
mtrofin
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the functions in make_corpus_lib assume they are working with a full file path whereas the tooling in extract_ir truncates the .bc/.cmd extensions and only has the object file. This discrepancy means that tooling that works with downstream products of corpora from extract_ir doesn't work without modification with corpora from make_corpus (ignoring the missing .cmd files). This patch makes make_corpus match the behavior of extract_ir.