Restrict push CI to main, fix permissions #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes two primary changes to the CI config. It restricts the CI running on push events to only run on the main branch. This prevents the CI from running twice on PRs from branches in the main repository, which are needed for stacked PRs. Additionally, this PR sets the permissions at the top of the file, which is a general best practice for Github workflows for security reasons.
mtrofin
approved these changes
Sep 13, 2024
boomanaiden154
added a commit
that referenced
this pull request
Sep 16, 2024
This patch makes two primary changes to the CI config. It restricts the CI running on push events to only run on the main branch. This prevents the CI from running twice on PRs from branches in the main repository, which are needed for stacked PRs. Additionally, this PR sets the permissions at the top of the file, which is a general best practice for Github workflows for security reasons. Additionally, bump a couple of the actions that were using deprecated NodeJS versions so we do not get the warning anymore.
boomanaiden154
added a commit
that referenced
this pull request
Sep 16, 2024
This patch makes two primary changes to the CI config. It restricts the CI running on push events to only run on the main branch. This prevents the CI from running twice on PRs from branches in the main repository, which are needed for stacked PRs. Additionally, this PR sets the permissions at the top of the file, which is a general best practice for Github workflows for security reasons. Additionally, bump a couple of the actions that were using deprecated NodeJS versions so we do not get the warning anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes two primary changes to the CI config. It restricts the CI running on push events to only run on the main branch. This prevents the CI from running twice on PRs from branches in the main repository, which are needed for stacked PRs.
Additionally, this PR sets the permissions at the top of the file, which is a general best practice for Github workflows for security reasons.
Additionally, bump a couple of the actions that were using deprecated NodeJS versions so we do not get the warning anymore.