Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAccTRec 2020 paper added and experiment script initial commit. #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ashudeep
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Aug 28, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Aug 28, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ashudeep
Copy link
Author

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Aug 28, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@yhalpern
Copy link
Collaborator

Hi Ashudeep,
This looks good overall.

2 Comments:

1 - It looks like there should be a change to ../movielens_recs_main.py in order to put these changes into effect.
2 - Rather than checking in movies,users,raters.csv, individuals should download them themselves from the movielens site using the script provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Has CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants