-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pbr iridescence API #4348
Add pbr iridescence API #4348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
return this[$backingThreeMaterial].iridescenceThicknessRange[1]; | ||
} | ||
|
||
get iridescenceThicknessTexture(): TextureInfo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed this function signature doesn't match the API: one returns TextureInfo
, while the other returns TextureInfo|null
. I noticed because of the !
below. This is probably true of the rest as well - let's make sure we know which is correct and then make them match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have these been added to the pbr map with createTextureInfo
? Maybe we need something more type-safe than a map...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, these are all added at $initialize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
* Add pbr iridescence API * Make pbr next properties api consistent for TextureInfo * Add Anisotropy
Follows threejs implementation.