Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poco: Use latest builder #12526

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

tyler92
Copy link
Contributor

@tyler92 tyler92 commented Sep 22, 2024

Also, unnecessary targets have been disabled to speed up compilation time and avoid issues with Clang 18.0.0 in Poco.Data.

Copy link

tyler92 has previously contributed to projects/poco. The previous PR was #12432

@jonathanmetzman
Copy link
Contributor

@DavidKorczynski thoughts?

@DavidKorczynski
Copy link
Collaborator

@tyler92 could you coordinate these contributions with the maintainers of poco?

#4736 and #5925 with relevant PRs.

Ideally we should land the targets in upstream repositories. @obiltschnig @aleks-f Recently @tyler92 has been contributing fuzzing to poco. could you help review the PRs?

@DavidKorczynski DavidKorczynski merged commit a081634 into google:master Sep 25, 2024
16 checks passed
@DavidKorczynski
Copy link
Collaborator

Please follow-up with upstreaming from the other PR

@tyler92
Copy link
Contributor Author

tyler92 commented Oct 2, 2024

@DavidKorczynski upstreaming: pocoproject/poco#4719 . I will update project/poco when that MR is merged.

DavidKorczynski pushed a commit that referenced this pull request Oct 11, 2024
Upstreaming after the discussion in
#12526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants