-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mageia to source_test.yaml (#2089) #2107
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
source_test.yaml
Outdated
- name: mageia | ||
versions_from_repo: False | ||
rest_api_url: 'https://advisories.mageia.org/vulns.json' | ||
type: 999 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be type: 2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
This source uses a standard JSON index with each vulnerability report at its own URL.
@dfandrich is there any chance you'd be able to sign the CLA: #2107 (comment)? We can't merge this sadly unless you do this. Alternatively, if you prefer, we can independently commit a similar change ourselves. |
@dfandrich is there any chance you'd be able to sign the CLA: #2107 (comment)?
Sorry, I completely missed this request. I'll look at it when I get a chance.
|
Circling back on this @dfandrich |
This pull request has not had any activity for 60 days and will be automatically closed in two weeks |
Automatically closing stale pull request |
I didn't see a way to approve this without creating a Google account. But, it seems unlikely to me that this PR is even copyrightable in the first place. Just in case it is, I hereby dedicate this commit to the public domain, or under the Creative Commons CC0 license (at the choice of the reader, or where applicable). So, go ahead and use it if you'd like anyway. |
Thanks @dfandrich, we'll be happy to just apply your changes on your behalf for this. |
It doesn't look like this ever made it into prod. Is it working in staging? |
@dfandrich thanks for flagging this, it looks like a PR to merge it into staging never got created, I've just sent out #3099 |
No other source seems to use the style of index Mageia has (not even Go,
which is was derived from), so this probably isn't useful as-is without
code changes.