-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Closing due to no activity in 3+ weeks. |
Hello kuhar, I noticed this PR was not merged. Please could you tell me the issues with this PR. I will fix it up. |
We require contributors to sign the CLA. See the comment made by the bot. |
Thank you, Please have a look here https://github.com/google/vulkan-performance-layers/pull/101/checks . I just signed it |
Thanks. I looked at the change and see a couple few issues:
|
Please did you mean |
We should check if libstdc++ is being used and if yest, link with the filesystem library for libstdc++ |
Hello @kuhar , sorry it took a while, I am still trying to get around CMake. Please is this the right approach ? if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
set(FILESYSTEM_LIB_NAME stdc++fs) |
detect when libstdc++ is used and only then link with the filesystem library for libstdc++
This PR does not seem to be moving forward. Closing so that it does not get mistaken as 'approved'. |
fixed #52