Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

changed stdc++fs to libc++ #101

Closed
wants to merge 2 commits into from
Closed

Conversation

Forchapeatl
Copy link

fixed #52

@google-cla
Copy link

google-cla bot commented Nov 2, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kuhar
Copy link
Contributor

kuhar commented Nov 25, 2022

Closing due to no activity in 3+ weeks.

@kuhar kuhar closed this Nov 25, 2022
@Forchapeatl
Copy link
Author

Hello kuhar, I noticed this PR was not merged. Please could you tell me the issues with this PR. I will fix it up.

@kuhar
Copy link
Contributor

kuhar commented Nov 25, 2022

Hello kuhar, I noticed this PR was not merged. Please could you tell me the issues with this PR. I will fix it up.

We require contributors to sign the CLA. See the comment made by the bot.

@Forchapeatl
Copy link
Author

Thank you, Please have a look here https://github.com/google/vulkan-performance-layers/pull/101/checks . I just signed it

@kuhar kuhar reopened this Nov 25, 2022
@kuhar
Copy link
Contributor

kuhar commented Nov 25, 2022

Thank you, Please have a look here https://github.com/google/vulkan-performance-layers/pull/101/checks . I just signed it

Thanks. I looked at the change and see a couple few issues:

  1. The change is stale now and needs to be rebased.
  2. We don't want to switch from libstdc++ to libc++ everywhere. Instead, we should detect when libstdc++ is used and only then link with the filesystem library for libstdc++.

@Forchapeatl
Copy link
Author

Forchapeatl commented Nov 25, 2022

We don't want to switch from libstdc++ to libc++ everywhere. Instead, we should detect when libstdc++ is used and only then link with the filesystem library for libstdc++.

Please did you mean
we should detect when libstdc++ is used and only then link with the filesystem library for libc++ ?

@kuhar
Copy link
Contributor

kuhar commented Nov 25, 2022

We should check if libstdc++ is being used and if yest, link with the filesystem library for libstdc++

@Forchapeatl
Copy link
Author

Forchapeatl commented Nov 29, 2022

We should check if libstdc++ is being used and if yest, link with the filesystem library for libstdc++

Hello @kuhar , sorry it took a while, I am still trying to get around CMake. Please is this the right approach ?

if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")  
    set(FILESYSTEM_LIB_NAME stdc++fs)

detect when libstdc++ is used and only then link with the filesystem library for libstdc++
@kuhar
Copy link
Contributor

kuhar commented Apr 20, 2023

This PR does not seem to be moving forward. Closing so that it does not get mistaken as 'approved'.

@kuhar kuhar closed this Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to use libc++ in CMake builds
3 participants