Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement changelog update functionality. #646

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

exzachlyvv
Copy link
Collaborator

@exzachlyvv exzachlyvv commented Oct 18, 2024

2 notes:

  • This PR correctly writes back to Cargo.toml file however the original format is not preserved. Any easy way to do that?
  • Not yet handling updates to crates that depend on originated change. That is next.

@exzachlyvv exzachlyvv requested a review from ia0 as a code owner October 18, 2024 16:50
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In parallel I'm looking to merge the existing code in main when I get the time.

crates/cli-tools/src/changelog.rs Outdated Show resolved Hide resolved
crates/cli-tools/src/changelog.rs Show resolved Hide resolved
crates/cli-tools/src/changelog.rs Outdated Show resolved Hide resolved
crates/cli-tools/src/changelog.rs Outdated Show resolved Hide resolved
crates/cli-tools/src/changelog.rs Outdated Show resolved Hide resolved
@exzachlyvv exzachlyvv requested a review from ia0 October 31, 2024 20:37
crates/cli-tools/src/changelog.rs Show resolved Hide resolved
@ia0 ia0 merged commit ba8f253 into google:dev/changelog Nov 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants