Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zvv/changelog internalize path #669

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

exzachlyvv
Copy link
Collaborator

Is there a good way to point a PR at another PR for diff?

I only want to send commit 80b4d5a for review, but after the other commits are merged.

@exzachlyvv exzachlyvv requested a review from ia0 as a code owner October 31, 2024 21:12
@ia0
Copy link
Member

ia0 commented Nov 1, 2024

Is there a good way to point a PR at another PR for diff?

You would essentially need to create the PR in your fork, and use the branch of your other PR as base branch.

Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

crates/cli-tools/src/changelog.rs Show resolved Hide resolved
crates/cli-tools/src/changelog.rs Outdated Show resolved Hide resolved
crates/cli-tools/src/changelog.rs Outdated Show resolved Hide resolved
@exzachlyvv exzachlyvv requested a review from ia0 November 7, 2024 15:54
@ia0 ia0 merged commit 5364dde into google:dev/changelog Nov 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants