Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take actions by value #672

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Take actions by value #672

merged 1 commit into from
Nov 7, 2024

Conversation

ia0
Copy link
Member

@ia0 ia0 commented Nov 7, 2024

No description provided.

@ia0 ia0 added crate:cli Modifies the users CLI for:maintainability Improves maintainers life labels Nov 7, 2024
@ia0 ia0 requested a review from ia0-review November 7, 2024 12:59
ia0-review
ia0-review approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@ia0-review ia0-review left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation behind this change?

@ia0
Copy link
Member Author

ia0 commented Nov 7, 2024

What's the motivation behind this change?

We want all actions to behave similarly regarding self (either by shared reference or by value) since we want to compose them (e.g. RustAppletInstall depends on RustAppletBuild and AppletInstall and possibly AppletExitStatus). Doing this by value is much simpler and most existing actions already do so. This is fixing historical actions.

@ia0 ia0 merged commit 1ce41e3 into google:main Nov 7, 2024
21 checks passed
@ia0 ia0 deleted the self branch November 7, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia0-review ia0-review ia0-review approved these changes

Assignees
No one assigned
Labels
crate:cli Modifies the users CLI for:maintainability Improves maintainers life
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ia0 @ia0-review