Support direct access with Service Account (#467)

googleads · Nov 14, 2023 · 426333c · 426333c
1 parent 88fc2ee
commit 426333c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/google/ads/google_ads/google_ads_client.rb b/lib/google/ads/google_ads/google_ads_client.rb
@@ -225,7 +225,6 @@ def get_updater_proc
         # Provides a Google::Auth::Credentials initialized with a keyfile
         # specified in the config.
         def get_service_account_credentials
-          raise 'config.impersonate required if keyfile specified' unless @config.impersonate
           keyfile = File.read(@config.keyfile)
           keyfile = JSON.parse(keyfile)
           Signet::OAuth2::Client.new(

diff --git a/test/test_google_ads_client.rb b/test/test_google_ads_client.rb
@@ -233,12 +233,14 @@ def test_default_to_updater_proc
   #   end
   # end
 
-  def test_keyfile_without_impersonate_raises
+  def test_crendetials_work_with_service_account_keyfile
     client = Google::Ads::GoogleAds::GoogleAdsClient.new do |config|
-      config.keyfile = 'keyfile'
+      config.keyfile = 'test/fixtures/keyfile.json'
     end
 
-    assert_raises do
+    assert_raises(OpenSSL::PKey::RSAError) do
+      # OpenSSL::PKey::RSAError means it read the test file and tried to
+      # initialize a key with it. Since it's not a valid key, it raises.
       client.get_credentials
     end
   end