Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support direct access with Service Account #467

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Support direct access with Service Account #467

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3db521a
Support direct access with Service Account
danielfrg Nov 14, 2023
50474fe
Update test
danielfrg Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/google/ads/google_ads/google_ads_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ def get_updater_proc
# Provides a Google::Auth::Credentials initialized with a keyfile
# specified in the config.
def get_service_account_credentials
raise 'config.impersonate required if keyfile specified' unless @config.impersonate
jradcliff marked this conversation as resolved.
Show resolved Hide resolved
keyfile = File.read(@config.keyfile)
keyfile = JSON.parse(keyfile)
Signet::OAuth2::Client.new(
Expand Down