Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(functions): fix invalid region tag #5640

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iennae
Copy link

@iennae iennae commented Aug 27, 2024

making sure this sample includes a valid region tag; it could be that this sample needs to be archived but in case it's in use within the repo for testing, making sure it's associated with the right region tag. Additionally, the region tag may need to change in the near future and this will make it more discoverable that it needs to be updated. Also recognize that functions_ is what's in the configuration, but functions is in broader use and cloudfunctions is the appropriate one.

@iennae iennae requested review from yoshi-approver and a team as code owners August 27, 2024 20:33
Copy link

snippet-bot bot commented Aug 27, 2024

Here is the summary of possible violations 😱

There is a possible violation for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: cloudfunctions Issues related to the Cloud Run functions API. label Aug 27, 2024
@iennae
Copy link
Author

iennae commented Aug 28, 2024

I made a very small change, and I'm very unclear why owlbot made a bunch of changes to other files that I didn't change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudfunctions Issues related to the Cloud Run functions API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants