Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: [gkeconnect] Update default transport type for Connect Gateway v1 client to "rest" #5798

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Nov 12, 2024

  • Regenerate this pull request now.

BREAKING CHANGE: gRPC support is being removed in favor of HTTP support, as gRPC is not currently supported by Connect Gateway.

PiperOrigin-RevId: 695803161

Source-Link: googleapis/googleapis@de97a5f

Source-Link: https://github.com/googleapis/googleapis-gen/commit/aebeaedede54545ee16e9c12af65cdba4371030d
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWdrZWNvbm5lY3QtZ2F0ZXdheS8uT3dsQm90LnlhbWwiLCJoIjoiYWViZWFlZGVkZTU0NTQ1ZWUxNmU5YzEyYWY2NWNkYmE0MzcxMDMwZCJ9

BEGIN_NESTED_COMMIT
feat!: [gkeconnect] Update default transport type for Connect Gateway v1beta1 client to "rest"
BREAKING CHANGE: gRPC support is being removed in favor of HTTP support, as gRPC is not currently supported by Connect Gateway.

PiperOrigin-RevId: 695487411

Source-Link: googleapis/googleapis@5257378

Source-Link: https://github.com/googleapis/googleapis-gen/commit/5dbaade6dc2f145aa1eaf33d0d8a052156a49088
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWdrZWNvbm5lY3QtZ2F0ZXdheS8uT3dsQm90LnlhbWwiLCJoIjoiNWRiYWFkZTZkYzJmMTQ1YWExZWFmMzNkMGQ4YTA1MjE1NmE0OTA4OCJ9
END_NESTED_COMMIT

…nt to "rest"

BREAKING CHANGE: gRPC support is being removed in favor of HTTP support, as gRPC is not currently supported by Connect Gateway.

PiperOrigin-RevId: 695487411

Source-Link: googleapis/googleapis@5257378

Source-Link: googleapis/googleapis-gen@5dbaade
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWdrZWNvbm5lY3QtZ2F0ZXdheS8uT3dsQm90LnlhbWwiLCJoIjoiNWRiYWFkZTZkYzJmMTQ1YWExZWFmMzNkMGQ4YTA1MjE1NmE0OTA4OCJ9
@dpebot
Copy link
Collaborator

dpebot commented Nov 12, 2024

/gcbrun

@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review November 12, 2024 01:12
@gcf-owl-bot gcf-owl-bot bot requested review from yoshi-approver and a team as code owners November 12, 2024 01:12
@dpebot
Copy link
Collaborator

dpebot commented Nov 12, 2024

/gcbrun

… "rest"

BREAKING CHANGE: gRPC support is being removed in favor of HTTP support, as gRPC is not currently supported by Connect Gateway.

PiperOrigin-RevId: 695803161

Source-Link: googleapis/googleapis@de97a5f

Source-Link: googleapis/googleapis-gen@aebeaed
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWdrZWNvbm5lY3QtZ2F0ZXdheS8uT3dsQm90LnlhbWwiLCJoIjoiYWViZWFlZGVkZTU0NTQ1ZWUxNmU5YzEyYWY2NWNkYmE0MzcxMDMwZCJ9
@gcf-owl-bot gcf-owl-bot bot changed the title feat!: [gkeconnect] Update default transport type for Connect Gateway v1beta1 client to "rest" feat!: [gkeconnect] Update default transport type for Connect Gateway v1 client to "rest" Nov 12, 2024
@dpebot
Copy link
Collaborator

dpebot commented Nov 12, 2024

/gcbrun

Copy link

snippet-bot bot commented Nov 12, 2024

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@dpebot
Copy link
Collaborator

dpebot commented Nov 12, 2024

/gcbrun

@sofisl sofisl added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 14, 2024
@sofisl
Copy link
Contributor

sofisl commented Nov 14, 2024

Let's wait until Node 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. owl-bot-copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants