feat: switch to picoquery for query string handling #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By switching to picoquery, we can gain a substantial perf boost (it is much faster than qs, and about the same speed as `fast-querystring`). Similarly, we can drop a few dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By switching to picoquery, we can gain a substantial perf boost (it is much faster than qs, and about the same speed as
fast-querystring). It is based onfast-querystring, but with support for nesting.Similarly, we can drop a few dependencies.
Note that this is part of the ongoing ecosystem-cleanup.
Important note:
The behaviour will slightly change here in that pq is stricter with syntax than qs. For example, it makes no sense to mix these two syntaxes:
foo=1&foo=2&foo[]=3. qs supports this at the cost of speed, while pq requires you to choose one.If you don't yet want to change this behaviour, there is another PR moving to
neoqsinstead. That will keep the same interface and behaviour with a much smaller change in performance.let me know and i'm happy to work with either!