CLN: use pydata-google-auth for auth flow #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only private_key logic and customized path for credentials cache remain. At some point in the future private_key logic will be removed, as that parameter is deprecated in favor of the credentials argument. Also removes the _try_credentials logic, as that slows down the authentication process and is largely unnecessary now that credentials can be explicitly created and supplied via the credentials argument.
max-sixty
approved these changes
Dec 20, 2018
| @@ -12,40 +12,34 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| CREDENTIALS_CACHE_DIRNAME = "pandas_gbq" | |||
| CREDENTIALS_CACHE_FILENAME = "bigquery_credentials.dat" | |||
There was a problem hiding this comment.
To confirm, you think we should have something specific for pandas_gbq rather than anything using pydata_google_auth?
There was a problem hiding this comment.
This was mostly to be backwards compatible. I guess people won't be too annoyed if we change the credentials location and they have to reauth?
Another concern is if they use the pydata_google_auth location, it may get confusing if they use that library with different scopes somewhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only private_key logic and customized path for credentials cache remain.
At some point in the future private_key logic will be removed, as that
parameter is deprecated in favor of the credentials argument.
Also removes the _try_credentials logic, as that slows down the
authentication process and is largely unnecessary now that credentials
can be explicitly created and supplied via the credentials argument.
Closes #161