Skip to content

Commit

Permalink
Increase timeout in apps test
Browse files Browse the repository at this point in the history
I'm not sure why, but it seems it takes sometimes ~one minute to delete
the old job, even though the underlying pod just runs `false` and should
terminate immediately. After bumping the timeout, the test passed 25
times in a row, whereas before it failed on the second attempt.

Fixes b/223331353.

Change-Id: Ice1760a9b7d51f47a3d0e052b62f2aa878c79618
GitOrigin-RevId: 86eb62aee3b09498c85d3cb13fae599c80bed02b
  • Loading branch information
drigz authored and copybara-github committed Mar 9, 2022
1 parent cc85f62 commit e27a03a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions src/go/tests/apps/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ go_test(
"//src/go/cmd/synk",
"@kubernetes_helm//:helm",
],
# TODO(b/223331353): fix flake
flaky = True,
rundir = ".",
tags = [
"requires-access-token",
Expand Down
2 changes: 1 addition & 1 deletion src/go/tests/apps/apps_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ func testUpdateChartAssignment_WithFixedJob_BecomesReady(t *testing.T, f *kubete

if err := backoff.Retry(
f.ChartAssignmentHasStatus(&ca, crcapps.ChartAssignmentPhaseReady),
backoff.WithMaxRetries(backoff.NewConstantBackOff(time.Second), 60),
backoff.WithMaxRetries(backoff.NewConstantBackOff(3*time.Second), 60),
); err != nil {
t.Fatalf("wait for chart assignment to go from Settled to Ready: %s", err)
}
Expand Down

0 comments on commit e27a03a

Please sign in to comment.