Drop more heavy metrics #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After these, we're down to useful metrics like node_cpu_seconds_total or grpc_io_client_roundtrip_latency_bucket which we wouldn't want to drop but perhaps relabel (for example to aggregate CPU usage across all CPUs rather than generating 8 metrics for all 30 or 100 vCPUs on every node, or to drop pod IDs from grpc client metrics so they're aggregated across different instances of the same client) but I've never tried this. Tested as for #453.
ensonic
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After these, we're down to useful metrics like node_cpu_seconds_total or
grpc_io_client_roundtrip_latency_bucket which we wouldn't want to drop
but perhaps relabel (for example to aggregate CPU usage across all CPUs
rather than generating 8 metrics for all 30 or 100 vCPUs on every node,
or to drop pod IDs from grpc client metrics so they're aggregated across
different instances of the same client) but I've never tried this.
Tested as for #453.