Cleanup robotauth tokensource config. #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leave the scopes empty This is optional and we already sent the data else where. I've deployed this to robco-ensonic and connected minikube to it. I also started hello-k8s and observed that the logs are captured in the cloud. Add some more comments on the other fields as well.
|
@Ongy Can you review this? I think you understand how these fields are used better so want to double-check this won't interfere with anything we're doing. |
Ongy
reviewed
Jan 29, 2025
Ongy
approved these changes
Jan 29, 2025
|
Yea, the fact that this isn't used is what caused me to write the interceptor in xfa-advertise instead of copying out this part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave the scopes empty
This is optional and we already sent the data else where. I've deployed this to robco-ensonic and connected minikube to it. I also started hello-k8s and observed that the logs are captured in the cloud.
Add some more comments on the other fields as well.