display error dialog prompting user to force upgrade buggy Python plugin

[anthrotype]

the old Glyphs Python plugin had an issue with the pip command, which has now been fixed in the latest version of that plugin. The upgrade should happen automatically I believe, but in any case it's better to tell the user they can manually remove and reinstall the Python plugin to overcome the issue

see schriftgestalt/glyphs-packages#146 (comment)

[anthrotype]

@schriftgestalt am I correct in thinking that I just need to bump the two version fields in the Info.plist for the Plugin Manager to detect that our fontc export plugin can be updated?

And are the plugin updates automatic (how frequent) or do users need to actively click upgrade somewhere?

[schriftgestalt]

No, the plugin manager just pulls whatever is in the repo.

[anthrotype]

wait, so even if I didn't change the versions it would still get updated?
and when will that occur?

[schriftgestalt]

The check is done when the app starts. The actual pulling when the app is closed. Otherwise the loaded plugin and the code on the disk would not agree.

[anthrotype]

The check

what check? you said it "just pulls whatever is in the repo", which I assume means the versions in Info.plist are irrelevant?

[schriftgestalt]

The check if there are new commits in the repo. @florianpircher did that code. So he might have more details.

[anthrotype]

got it, thank you. So what's the use of the version strings? I can't even see those displayed anywhere in the UI

[schriftgestalt]

the version string is a leftover from Glyphs 2.

You can remove those keys from the info.plist. But increase the CFBundleVersion every time you change something. And the CFBundleShortVersionString for bigger changes.

[anthrotype]

oh, in that case I won't touch them. I reverted the commit that bumped them

[anthrotype]

so how can one force some plugin to be updated? by closing and reopening the app a couple times?

[anthrotype]

You can remove those keys from the info.plist. But increase the CFBundleVersion every time you change something. And the CFBundleShortVersionString for bigger changes.

i'm confused. Should I remove them or increase them?!

[florianpircher]

When Glyphs launches, it fetches all repositories. As it is doing that, Glyphs checks whether the HEAD commit changed between before and after the fetch. If it did change, Glyphs considers that an update. Just as Glyphs is quit, the app resets the updated repositories to the fetched update. So the checking for updates and downloading new content is happening at launch, installing that new content is quickly done when quitting.

You can force an update by uninstalling and reinstalling. This is something that we will address better in the UI, but that will have to wait for the next bigger UI rework.

[florianpircher]

The versions strings in the bundle’s Info.plist are good to keep around and increment. They are part for a well-formed bundle. And while their values are currently not displayed to the user in the Plugin Manager, they still show up when the plugin crashes so you know what version a user has when they report a crash of your plugin.

[anthrotype]

thanks for the clarifications
I'll keep them!

[schriftgestalt]

I meant you should remove those:UpdateFeedURL, productPageURL, productReleaseNotes. The CFBundleVersion, CFBundleShortVersionString are from apple and needed.

[anthrotype]

so from what I understand we can simply wait and do nothing, this dialog about the Glyphs Python plugin not working with pip is transient and will go away as soon as people close and start their app a couple of times to automatically obtain the latest copy. I think I'll just close this