Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Schema Validation for customCertSecretPath #4111

Closed
Joseph-Irving opened this issue Feb 12, 2025 · 1 comment · Fixed by #4112 · May be fixed by #4120
Closed

Helm Schema Validation for customCertSecretPath #4111

Joseph-Irving opened this issue Feb 12, 2025 · 1 comment · Fixed by #4112 · May be fixed by #4120
Labels
kind/bug These are bugs.

Comments

@Joseph-Irving
Copy link

What happened:
Starting from the 1.47.0 Helm chart an error occurs when trying to set customCertSecretPath

Error: values don\'t meet the specifications of the schema(s) in the following chart(s):\u000Aagones:\u000A- agones.extensions.customCertSecretPath: Invalid type. Expected: object, given: array

This is preventing us from using the update helm chart as we rely on custom certs.

What you expected to happen:
I expected the values to be applied as they did prior to this version.
I see in the schema https://github.com/googleforgames/agones/blob/v1.47.0/install/helm/agones/values.schema.json#L437

            "customCertSecretPath": {
              "type": "object"
            },

customCertSecretPath has been set to type object, however I believe this should be an array as per https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.30/#secretvolumesource-v1-core
items is an array of objects not a single object.
How to reproduce it (as minimally and precisely as possible):
Try setting the customCertSecretPath value e.g

 controller:
      customCertSecretPath:
      - key: ca.crt
        path: ca.crt
      - key: tls.crt
        path: server.crt
      - key: tls.key
        path: server.key

Anything else we need to know?:

Environment:

  • Agones version: 1.47.0
  • Kubernetes version (use kubectl version): v1.30.9
  • Cloud provider or hardware configuration: EKS
  • Install method (yaml/helm): helm
  • Troubleshooting guide log(s):
  • Others:
@Joseph-Irving Joseph-Irving added the kind/bug These are bugs. label Feb 12, 2025
@markmandel
Copy link
Collaborator

As a workaround, -skip-schema-validation should turn off the validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs.
Projects
None yet
2 participants