Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: change type from object to array for controller.customCertSecre… #4120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Joseph-Irving
Copy link

/kind hotfix

What this PR does / Why we need it:
This PR #4112 fixed extensions.customCertSecretPath by changing it to array but the same field needs changing in controller.customCertSecretPath
Which issue(s) this PR fixes:

Closes #4111

Special notes for your reviewer:

Copy link

google-cla bot commented Feb 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Joseph-Irving
Copy link
Author

I'm having difficulties signing the CLA, yesterday I got 400 bad request, today I'm getting A server error occurred, please try your request again so I'm gonna assume has gone wrong on the google side with this form.

@igooch
Copy link
Collaborator

igooch commented Mar 3, 2025

/gcbrun

@igooch
Copy link
Collaborator

igooch commented Mar 3, 2025

I'm having difficulties signing the CLA, yesterday I got 400 bad request, today I'm getting A server error occurred, please try your request again so I'm gonna assume has gone wrong on the google side with this form.

@Joseph-Irving are you still having issues signing the CLA?

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 316e540f-1677-4db0-8898-370f165bd493

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: a5f216ce-32c2-4c6b-a328-ec63ab31a21b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4120/head:pr_4120 && git checkout pr_4120
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-765edcd

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igooch igooch enabled auto-merge (squash) March 3, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/hotfix Hotfixes for issues against release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Schema Validation for customCertSecretPath
3 participants