-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: change type from object to array for controller.customCertSecre… #4120
base: main
Are you sure you want to change the base?
helm: change type from object to array for controller.customCertSecre… #4120
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I'm having difficulties signing the CLA, yesterday I got 400 bad request, today I'm getting |
/gcbrun |
@Joseph-Irving are you still having issues signing the CLA? |
Build Failed 😭 Build Id: 316e540f-1677-4db0-8898-370f165bd493 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 🥳 Build Id: a5f216ce-32c2-4c6b-a328-ec63ab31a21b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/kind hotfix
What this PR does / Why we need it:
This PR #4112 fixed
extensions.customCertSecretPath
by changing it to array but the same field needs changing incontroller.customCertSecretPath
Which issue(s) this PR fixes:
Closes #4111
Special notes for your reviewer: