-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fleet: Allow increasing the fleet replicas during a rolling update #3977
base: main
Are you sure you want to change the base?
fleet: Allow increasing the fleet replicas during a rolling update #3977
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Build Failed 😭 Build Id: 5b824c81-d928-421c-a81a-0d1977863049 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😭 Build Id: 64243212-5c9f-4cdf-bc35-27cd5a566d28 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Do you think #3762 fixes your use case? |
This PR hasn't been updated since September -- I'm thinking we close this. @igooch , @gongmax, @GonzaloSaez any objections? |
@markmandel I'm okay with closing this but I still think we should still fix the issue linked to this PR since it disallows rolling updates if the fleet is full. |
@GonzaloSaez you never said if |
Sorry I forgot to answer that one. I don't think that |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Addresses #3970 by adding an extra boolean option to the fleet strategy that allows scaling up the replica count based on the
RollingUpdate
settings when patching the fleet config. This allows fleets to behave a bit more like aDeployment
when there is a redeployment. The new feature unblocks fleets that have all their replicas inAllocated
state at the same time that a fleet update is requested. Previously, the newGameServerSet
would get stuck until one of the fleet'sGameServer
was deleted/brought back toReady
state.Which issue(s) this PR fixes:
Closes #3970
Special notes for your reviewer:
I'm not sure if this is a feature that the Agones maintainer want to support moving forward. This feature is useful for some of my use cases and it'd be difficult for me to maintain it ouside this repo. Happy to hear the opinions of others regarding this new functionality.