Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON Schema validation for ServiceAccount annotations #4122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xaravindh
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / Why we need it:

  • Updated serviceaccount.*.annotations schema to allow key-value string pairs.
  • Changed additionalProperties from type: string to type: object.
  • Resolves issue preventing Helm chart installation when annotations are provided.

Which issue(s) this PR fixes:

Closes #4119

Special notes for your reviewer:

- Updated `serviceaccount.*.annotations` schema to allow key-value string pairs.
- Changed `additionalProperties` from `type: string` to `type: object`.
- Resolves issue preventing Helm chart installation when annotations are provided.
- Closes googleforgames#4119.
@0xaravindh 0xaravindh self-assigned this Mar 5, 2025
@github-actions github-actions bot added the kind/bug These are bugs. label Mar 5, 2025
@0xaravindh 0xaravindh requested review from igooch and gongmax March 5, 2025 15:28
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 24722a91-abd1-4d5c-8505-049d7bb8089f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4122/head:pr_4122 && git checkout pr_4122
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-d43c88d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Schema does not match helm chart structure for serviceaccount.*.annotations
2 participants