fix: fixed crash when the Bitmap size is zero in the ClusterRenderer #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikoso
added
the
priority: p1
kikoso
force-pushed
the
fix/fixed_crash_when_bitmap_size_is_zero_in_clusterrenderer
branch
from
c15716f
to
016d7de
Compare
wangela
approved these changes
Jul 19, 2023
4 tasks
wangela
deleted the
fix/fixed_crash_when_bitmap_size_is_zero_in_clusterrenderer
branch
googlemaps-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
## [2.11.5](v2.11.4...v2.11.5) (2023-07-25) ### Bug Fixes * fixed crash when the Bitmap size is zero in the ClusterRenderer ([#336](#336)) ([93b9b85](93b9b85))
|
🎉 This PR is included in version 2.11.5 🎉 The release is available on:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents a crash when the Bitmap size is zero in the ClusterRenderer.
measuredWidthandmeasuredHeighttypically return 0 when we call them fromonCreate, which does not seem to be the case. This is also not deterministic and not always reproducible. For some reason, the view has not been drawn when we hit this point.This PR will prevent the crash, although the causes need to be determined.
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #297