Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Implementation smells #937

Closed
wants to merge 8 commits into from

Merge branch 'main' into fix-design-smells

c817226
Select commit
Loading
Failed to load commit list.
Closed

Fix Implementation smells #937

Merge branch 'main' into fix-design-smells
c817226
Select commit
Loading
Failed to load commit list.
In Solidarity / Inclusive Language completed Nov 28, 2023 in 2s

Check completed with warnings

Configuration

Below is the configuration used for this check run:

rules:
  master:
    regex:
      - /master/gi
    level: warning
    alternatives:
      - primary
      - main
      - leader
      - active
      - writer
  slave:
    regex:
      - /slave/gi
    level: failure
    alternatives:
      - secondary
      - node
      - worker
      - replica
      - passive
  whitelist:
    regex:
      - /white[_-]*list/gi
    level: failure
    alternatives:
      - include list
      - allow list
  blacklist:
    regex:
      - /black[_-]*list/gi
    level: failure
    alternatives:
      - exclude list
      - deny list
  grandfathered:
    regex:
      - /grandfathered/gi
    level: 'off'
    alternatives:
      - legacied
      - exempted
  sanity_check:
    regex:
      - /sanity[_-]*check/gi
    level: 'off'
    alternatives:
      - smoke test
      - confidence check
  man_hours:
    regex:
      - /man[_-]*hours/gi
    level: 'off'
    alternatives:
      - person-hours
      - human-hours
ignore:
  - dist/
  - .github/
defaultMessage: >

  Please consider an alternative to `{{match}}`. 

  {{#if alternatives~}}


  Possibilities include: {{#each alternatives}}{{#if @index}},
  {{/if}}`{{this}}`{{/each}}

  {{~/if}}

For more information on configuration and rules, check the documentation.

App version

Annotations

Check warning on line 32 in .github/sync-repo-settings.yaml

See this annotation in the file changed.

@in-solidarity in-solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. 
Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi

Check warning on line 325 in CHANGELOG.md

See this annotation in the file changed.

@in-solidarity in-solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. 
Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi

Check warning on line 737 in CHANGELOG.md

See this annotation in the file changed.

@in-solidarity in-solidarity / Inclusive Language

Match Found

Please consider an alternative to `master`. 
Possibilities include: `primary`, `main`, `leader`, `active`, `writer`
Raw output
/master/gi