Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add minimal support for Debian pre-dependencies #696

Merged
merged 4 commits into from
Aug 15, 2023

Conversation

jeremy-gill
Copy link
Contributor

Basic support for adding 'Pre-Depends:' to Debian packages added.

Basic support for adding 'Pre-Depends:' to Debian packages added.
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 10, 2023
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment with some improvement suggestions.

can you also please update the docs and add a test?

thank you for the PR :)

nfpm.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2023
@jeremy-gill
Copy link
Contributor Author

@caarlos0, I've moved the 'predepends' tag from the platform-independent area to a Debian-specific location. I've also tweaked deb/deb_test.go to provide some minimal testing of the new tag. Finally, I updated the www/docs/configuration.md to explain the use of the new tag. Is this the change you were looking for?

@caarlos0 caarlos0 added the enhancement New feature or request label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #696 (94b5690) into main (24a43c5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
+ Coverage   75.02%   75.03%   +0.01%     
==========================================
  Files          10       10              
  Lines        2406     2407       +1     
==========================================
+ Hits         1805     1806       +1     
  Misses        425      425              
  Partials      176      176              
Files Changed Coverage Δ
deb/deb.go 72.42% <ø> (ø)
nfpm.go 85.06% <100.00%> (+0.06%) ⬆️

@caarlos0
Copy link
Member

thank you, I'll add an integration test too.

@caarlos0 caarlos0 merged commit 3aded35 into goreleaser:main Aug 15, 2023
40 of 41 checks passed
@github-actions github-actions bot added this to the v2.27.0 milestone Aug 15, 2023
caarlos0 added a commit that referenced this pull request Aug 15, 2023
refs #696

Signed-off-by: Carlos Alexandro Becker <[email protected]>
caarlos0 added a commit that referenced this pull request Aug 16, 2023
* test: deb.predepends integration test

refs #696

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* fix: test

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* fix: typo

---------

Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 modified the milestones: v2.27.0, v2.33.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants