Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpm): conventional file name should always have the release #701

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Sep 1, 2023

closes #700

@caarlos0 caarlos0 added the bug Something isn't working label Sep 1, 2023
@caarlos0 caarlos0 self-assigned this Sep 1, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 1, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8abae3a
Status: ✅  Deploy successful!
Preview URL: https://790fedb9.nfpm.pages.dev
Branch Preview URL: https://rpm-release.nfpm.pages.dev

View logs

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #701 (8abae3a) into main (b50fc3a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
- Coverage   75.03%   75.02%   -0.02%     
==========================================
  Files          10       10              
  Lines        2407     2406       -1     
==========================================
- Hits         1806     1805       -1     
  Misses        425      425              
  Partials      176      176              
Files Changed Coverage Δ
rpm/rpm.go 70.81% <100.00%> (-0.11%) ⬇️

@caarlos0 caarlos0 merged commit cb2d7bd into main Sep 12, 2023
40 of 42 checks passed
@caarlos0 caarlos0 deleted the rpm-release branch September 12, 2023 12:59
@github-actions github-actions bot added this to the v2.27.0 milestone Sep 12, 2023
@caarlos0 caarlos0 modified the milestones: v2.27.0, v2.33.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch in rpm package produced by nfpm and it's corresponding ConventionalFileName
1 participant