Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add set zoom and coordinates features #71

Merged
merged 12 commits into from
Sep 29, 2024
Merged

Conversation

Lucifer-02
Copy link
Contributor

Those features are implemented by adding more parameters to the Google Maps URL:

  • zoom: Change the zoom level in the map view.
  • coordinates: set coordinates to search on the map.

@gosom
Copy link
Owner

gosom commented Sep 27, 2024

@Lucifer-02 thanks for the pull request. Appreciated

Do you mind to take care of the linter issues also?

  Running [/home/runner/golangci-lint-1.61.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Warning: var-naming: var mapUrl should be mapURL (revive)
  Error: if statements should only be cuddled with assignments (wsl)
  
  level=warning msg="[config_reader] The output format `github-actions` is deprecated, please use `colored-line-number`"
  
  Error: issues found

main.go Outdated Show resolved Hide resolved
@Lucifer-02
Copy link
Contributor Author

Sorry for this carelessness!

gmaps/job.go Outdated Show resolved Hide resolved
gmaps/job.go Outdated Show resolved Hide resolved
@gosom
Copy link
Owner

gosom commented Sep 28, 2024

@Lucifer-02 can you also please resolve the conflics with the main?

P.S. I can do my self but I guess you prefer to have the commits. If that is not the case then I can takeover the PR.

Thanks again for your contribution

@Lucifer-02
Copy link
Contributor Author

@Lucifer-02 can you also please resolve the conflics with the main?

P.S. I can do my self but I guess you prefer to have the commits. If that is not the case then I can takeover the PR.

Thanks again for your contribution

@Lucifer-02 Lucifer-02 closed this Sep 28, 2024
@Lucifer-02
Copy link
Contributor Author

@Lucifer-02 can you also please resolve the conflics with the main?

P.S. I can do my self but I guess you prefer to have the commits. If that is not the case then I can takeover the PR.

Thanks again for your contribution

Yeah, this is my first PR and I'm a newbie at Go

@Lucifer-02 Lucifer-02 reopened this Sep 28, 2024
@Lucifer-02 Lucifer-02 reopened this Sep 28, 2024
@gosom gosom merged commit 9f598b0 into gosom:main Sep 29, 2024
1 check passed
@gosom
Copy link
Owner

gosom commented Sep 29, 2024

@Lucifer-02 merged.

Thank you .

Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants