Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use comment.Maps.IgnorePos() instead of IgnoreLine() #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daichimukai
Copy link

nilerr sometimes fails to find lint:ignore comments. This is because
nilerr checks if this comment exists by comment.Maps.IgnoreLine(),
which does not work well with multiple files. For example, nilerr
mistakenly ignores lint:ignore with the following files.

-- f.go --
package main

import "errors"

func f() error {
        err := errors.New("error")
        if err != nil {
                //lint:ignore nilerr reason
                return nil
        }
        return nil
}

-- g.go --
package main

import "errors"

func g() error {
        err := errors.New("error")
        if err != nil {
                // not ignored
                return err
        }
        return nil
}

This patch changes to use IgnorePos() that is safe to use with
multiple files.

nilerr sometimes fails to find `lint:ignore` comments. This is because
nilerr checks if this comment exists by `comment.Maps.IgnoreLine()`,
which does not work well with multiple files. For example, nilerr
mistakenly ignores `lint:ignore` with the following files.

-- f.go --
package main

import "errors"

func f() error {
        err := errors.New("error")
        if err != nil {
                //lint:ignore nilerr reason
                return nil
        }
        return nil
}

-- g.go --
package main

import "errors"

func g() error {
        err := errors.New("error")
        if err != nil {
                // not ignored
                return err
        }
        return nil
}

This patch changes to use `IgnorePos()` that is safe to use with
multiple files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant