Skip to content

Commit

Permalink
fix: test v2 manifest instead of v12
Browse files Browse the repository at this point in the history
  • Loading branch information
@sabino
sabino committed Nov 27, 2024
1 parent 135142e commit bd849dd
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 19 deletions.
19 changes: 6 additions & 13 deletions tests/fixtures/manifest-v12.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@
"schema": null,
"database": null,
"tags": [],
"meta": {
"metabase.description": "This table has basic information about payments"
},
"meta": {},
"group": null,
"materialized": "table",
"incremental_strategy": null,
Expand All @@ -64,6 +62,7 @@
"access": "protected"
},
"tags": [],
"description": "This table has basic information about payments",
"columns": {
"payment_id": {
"name": "payment_id",
Expand All @@ -87,9 +86,7 @@
"payment_method": {
"name": "payment_method",
"description": "",
"meta": {
"metabase.description": "The method used to complete a payment."
},
"meta": {},
"data_type": null,
"constraints": [],
"quote": null,
Expand Down Expand Up @@ -124,9 +121,7 @@
"tags": []
}
},
"meta": {
"metabase.description": "This table has basic information about payments"
},
"meta": {},
"group": null,
"docs": {
"show": true,
Expand Down Expand Up @@ -198,8 +193,7 @@
"database": null,
"tags": [],
"meta": {
"metabase.display_name": "clients",
"metabase.description": "Contains customer details and derived order facts"
"metabase.display_name": "clients"
},
"group": null,
"materialized": "table",
Expand Down Expand Up @@ -296,8 +290,7 @@
}
},
"meta": {
"metabase.display_name": "clients",
"metabase.description": "Contains customer details and derived order facts"
"metabase.display_name": "clients"
},
"group": null,
"docs": {
Expand Down
8 changes: 6 additions & 2 deletions tests/fixtures/manifest-v2.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@
"status": {
"name": "status",
"description": "Orders can be one of the following statuses:\n\n| status | description |\n|----------------|------------------------------------------------------------------------------------------------------------------------|\n| placed | The order has been placed but has not yet left the warehouse |\n| shipped | The order has ben shipped to the customer and is currently in transit |\n| completed | The order has been received by the customer |\n| return_pending | The customer has indicated that they would like to return the order, but it has not yet been received at the warehouse |\n| returned | The order has been returned by the customer and received at the warehouse |",
"meta": {},
"meta": {
"metabase.description": "Order status: placed, shipped, completed, return_pending, or returned."
},
"data_type": null,
"quote": null,
"tags": []
Expand Down Expand Up @@ -145,7 +147,9 @@
"tags": []
}
},
"meta": {},
"meta": {
"metabase.description": "Basic and derived order information from payments"
},
"docs": {
"show": true
},
Expand Down
8 changes: 4 additions & 4 deletions tests/test_manifest.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def test_v12():
),
Column(
name="payment_method",
description="The method used to complete a payment.",
description="",
),
Column(
name="order_id",
Expand All @@ -60,7 +60,7 @@ def test_v12():
group=Group.nodes,
name="customers",
alias="customers",
description="Contains customer details and derived order facts",
description="This table has basic information about a customer, as well as some derived facts based on a customer's orders",
display_name="clients",
unique_id="model.sandbox.customers",
columns=[
Expand Down Expand Up @@ -258,7 +258,7 @@ def test_v2():
group=Group.nodes,
name="orders",
alias="orders",
description="This table has basic information about orders, as well as some derived facts based on payments",
description="Basic and derived order information from payments",
unique_id="model.jaffle_shop.orders",
columns=[
Column(
Expand All @@ -278,7 +278,7 @@ def test_v2():
),
Column(
name="status",
description="Orders can be one of the following statuses:\n\n| status | description |\n|----------------|------------------------------------------------------------------------------------------------------------------------|\n| placed | The order has been placed but has not yet left the warehouse |\n| shipped | The order has ben shipped to the customer and is currently in transit |\n| completed | The order has been received by the customer |\n| return_pending | The customer has indicated that they would like to return the order, but it has not yet been received at the warehouse |\n| returned | The order has been returned by the customer and received at the warehouse |",
description="Order status: placed, shipped, completed, return_pending, or returned.",
),
Column(
name="amount",
Expand Down

0 comments on commit bd849dd

Please sign in to comment.